|
From: José F. <jfo...@vm...> - 2010-12-06 20:31:34
|
On Mon, 2010-12-06 at 00:09 -0800, Chia-I Wu wrote: > On Fri, Dec 3, 2010 at 2:21 PM, Chia-I Wu <ol...@gm...> wrote: > > On Fri, Dec 3, 2010 at 3:39 AM, José Fonseca <jfo...@vm...> wrote: > >> Hi Olv, > >> > >> Vega state tracker started failing to build on windows when I enabled > >> Win32 threads everywhere. The problem is that windows.h defines > >> CreateFont as CreateFontA. > >> > >> I looked at the code, but it was very hard to understand how to tackle > >> this, due to the mixture of both C-preprocessor and Python scripted code > >> generation makes things very obfuscated. > >> > >> Some ideas for the future: > >> > >> - The point of APIs like OpenVG having unique prefixes like "vg" is to > >> prevent this sort of name collision, but these macros which concatenate > >> the prefix/suffix end up defeating it. > >> > >> - Also given that we're using code generation, I think it would be > >> better if we just generate everything from the python script without the > >> c-preprocessor magic. > >> Anyway, pretty nice seeing the VG state tracker getting love! > > I overlooked this issue while working on the dispatcher. I will make > > a switch to python scripts (or maybe simply use glapi). > This should be fixed by 8f2a974cf2c9. The python script is rewritten > to generate real C code. Excellent! Much easier to read and understand what the mapi_abi.py's output. Thanks. Jose |