Re: [Mesa3d-dev] [PATCH] demos: import GLSL raytracing demos

[RALOVICH, K. <kri...@gm...>]

On Wed, Apr 14, 2010 at 17:49, Eric Anholt <er...@an...> wrote:
> On Sun, 28 Mar 2010 17:52:16 -0400, RALOVICH, Kristóf <kri...@gm...> wrote:
>> Eric,
>>
>> please see the attached patch for piglit. The patch includes 2 new
>> tests based on the demos I provided for mesa.
>>
>> Let me know if I can further help!
>
> The main thing I'm concerned about is that you seem to be looking for
> pixel-precise results.  Do you expect that from this code?  Generally in
> piglit we try to construct some environment that gets a few consistent
> results and probe a few representative pixels out of it.

I'll update the patch based on Brian's conclusion to address this.

>
> Beyond that, since you didn't use git send-email, the patch came out
> mangled and I couldn't apply it to try it out.
>

The patch is actually an attachment to the email. Try saving it as
that, not copy-pasting from the email's text.

Kristof