Re: [Mesa3d-dev] [PATCH] demos: import GLSL raytracing demos

[RALOVICH, K. <kri...@gm...>]

Brian,

you are right, maybe more freedom should be allowed, but
piglit_probe_pixel_rgb() already uses 0.01 as threshold which should
be enough if the ray directions do not have large FP differences.

As a short term goal with the test vsraytrace was, that it should not
take my GM4500 down.

As a longer term solution we can allow e.g. 15% of pixels to even fail
piglit_probe_pixel_rgb() too. I can extend the patch with this if
you'd like it.

Kristof

On Wed, Apr 14, 2010 at 16:49, Brian Paul <br...@vm...> wrote:
> It looks like the piglit tests use an image comparison to determine
> pass/fail, right?
>
> That may not be too reliable since different drivers will produce slightly
> different results.
>
> Is there any way that the rendering can be checked for correctness without
> relying on an exact image comparison?
>
> -Brian
>
>
> RALOVICH, Kristóf wrote:
>>
>> Would someone please have a look at this piglit tests?
>>
>> Thanks,
>> Kristof
>>
>> On Sun, Mar 28, 2010 at 17:52, RALOVICH, Kristóf
>> <kri...@gm...> wrote:
>>>
>>> Eric,
>>>
>>> please see the attached patch for piglit. The patch includes 2 new
>>> tests based on the demos I provided for mesa.
>>>
>>> Let me know if I can further help!
>>>
>>> Thanks,
>>> Kristof
>>>
>>> On Wed, Mar 24, 2010 at 16:33, Eric Anholt <er...@an...> wrote:
>>>>
>>>> On Wed, 24 Mar 2010 11:10:47 -0400, RALOVICH, Kristóf
>>>> <kri...@gm...> wrote:
>>>>>
>>>>> Brian,
>>>>>
>>>>> that was fast! Who do you think I should bug, to get these working on
>>>>> i965?
>>>>>
>>>>> Also as my time allows, I am planning to extend them with mouse input
>>>>> for orientation and arrow keys for moving to camera to become more
>>>>> interactive.
>>>>
>>>> Make a testcase for piglit, and I'd love to fix your bug.
>>>>
>
>