Re: [Mesa3d-dev] [PATCH] glx: Fix config chooser logic for 'mask' matching

[Kristian H. <kr...@bi...>]

2010/4/9 Ian Romanick <id...@fr...>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Kristian Høgsberg wrote:
>> When matching attributes using the 'mask' matching criteria, the spec
>> says that
>>
>>   "Only GLXFBConfigs for which the set bits of attribute include all
>>    the bits that are set in the requested value are
>>    considered. (Additional bits might be set in the attribute)."
>>
>> The current test returns true if the two bit masks have bits in
>> common, specifically it matches even if the requested value has bits
>> set that are not set in the fbconfig attribute.  For example, an
>> application asking for
>>
>>   GLX_DRAWABLE_TYPE, GLX_PIXMAP_BIT | GLX_PBUFFER_BIT,
>>
>> as glxpbdemo does, will match fbconfigs that don't support pbuffer
>> rendering, as long as they support pixmap rendering.
>
> Reviewed-by: Ian Romanick <ian...@in...>

Thanks.

> This should go into master, 7.8, and mesa_7_7_branch.

Done.

> Are there any
> specific bugs associated with this?  If so, those should be documented
> in the commit message.

Not that I know.  I just ran into it when trying to run glxpbdemo.

Kristian