Re: [Mesa3d-dev] gallium-resources branch merge

[Marek O. <ma...@gm...>]

On Wed, Apr 7, 2010 at 7:01 PM, Keith Whitwell <ke...@vm...> wrote:

> On Tue, 2010-04-06 at 03:28 -0700, Keith Whitwell wrote:
> > On Fri, 2010-04-02 at 23:23 -0700, Marek Olšák wrote:
> > > There's something fishy in u_upload_mgr, could you please review the
> > > first two patches here?
> > > http://cgit.freedesktop.org/~mareko/mesa/log/?h=gallium-resources<http://cgit.freedesktop.org/%7Emareko/mesa/log/?h=gallium-resources>
> > >
> > > With this, r300g works again.
> >
> > Hmm, I think the second of the patches (flush range relative to mapped
> > range vs whole buffer) may be addressing a regression that has creeped
> > into the -resources branch regarding this behaviour - ie. I think the
> > code you modified was actually correct, but that
> > pipe_flush_mapped_buffer_range() has changed to do the wrong thing.
> >
> > I'll try and figure out what should be happening.
>
> I've pushed a change which hopefully corrects the behaviour of the
> buffer_range inlines.  Can you give it a try?
>

Now glean/bufferObject fails on softpipe and r300g. I haven't tested other
drivers.

-Marek