Re: [Mesa3d-dev] ARB draw buffers + texenv program

[Brian P. <br...@vm...>]

Dave Airlie wrote:
> Just going down the r300g piglit failures and noticed fbo-drawbuffers
> failed, I've no idea
> if this passes on Intel hw, but it appears the texenvprogram really
> needs to understand the
> draw buffers. The attached patch fixes it here for me on r300g anyone
> want to test this on Intel
> with the piglit test before/after?

The piglit test passes as-is with Mesa/swrast and NVIDIA.

It fails with gallium/softpipe both with and w/out your patch.

I think that your patch is on the right track.  But multiple render 
targets are still a bit of an untested area in the st/mesa code.

One thing: the patch introduces a dependency on buffer state in the 
texenvprogram code so in state.c we should check for the _NEW_BUFFERS 
flag.

Otherwise, I'd like to debug the softpipe failure a bit further to see 
what's going on.  Perhaps you could hold off on committing this for a 
bit...

-Brian