From: tom f. <tf...@al...> - 2010-04-04 16:53:42
|
Jeremy Huddleston <jer...@fr...> writes: > > On Apr 3, 2010, at 12:34, tom fogal wrote: > > > Vinson Lee <vl...@vm...> writes: > >> Leopard uses gcc-4.0, which didn't have built-in support for atomic > >> variables. > > > > u_atomic.h should probably check for a supported compiler; Jeremy, does > > the attached patch produce an understandable error instead of a link > > error? > > Yeah, that bails appropriately, but the message should probably be soemthing > more like: > > #error "galium requires a compiler that supports gcc atomics." I see Vinson committed a better fix to the 7.8 branch. However, Vinson, I think you made a typo: #elif defined(PIPE_CC_GCC) && (PIPE_CC_GCC_VERSION >= 401) That version should be "410", not "401", right? -tom |