[Mesa3d-dev] [Bug 17659] driver_configs never deallocated

[<bug...@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=17659





--- Comment #2 from Kristof Ralovich <kri...@gm...>  2010-03-29 12:54:52 PST ---
(In reply to comment #1)
> (In reply to comment #0)
> > Created an attachment (id=19010)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=19010) [details] [details]
> > half-hearted demo patch which makes valgrind shutup
> > 
> > in src/glx/x11/drisw_glx.c 
> > 
> > const __DRIconfig **driver_configs;
> > 
> > psc->swrast->createNewScreen(screen,
> >     loader_extensions, &driver_configs, psc);
> > 
> > allocates space for the driver_configs which never get released afaics
> > 
> 
> You are right that they are not freed. The problem exists for actual DRI
> drivers also and for other loaders (xserver/glx ...).
> 
> So unless the configs are used by the loader after screen destruction time, I
> think that they should be freed by the common dri code under
> src/mesa/drivers/dri/common in the .DestroyScreen hook.
> 

I don't have the time to look into the code right now, but I had this patch
merged once
http://cgit.freedesktop.org/mesa/mesa/commit/?id=fa5b0364f90be19bb0e1915f1eea691d06fb8929


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.