Re: [Mesa3d-dev] [PATCH] st/mesa: make st_manager.c set have[Stencil|Depth]Buffer only if bits > 0

[Brian P. <br...@vm...>]

Luca Barbieri wrote:
> Fixes a segfault when clearing a non-existent stencil buffer.
> ---
>  src/mesa/state_tracker/st_manager.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c
> index ca3a29c..cac62e4 100644
> --- a/src/mesa/state_tracker/st_manager.c
> +++ b/src/mesa/state_tracker/st_manager.c
> @@ -333,15 +333,15 @@ st_visual_to_context_mode(const struct st_visual *visual,
>     }
>  
>     if (visual->depth_stencil_format != PIPE_FORMAT_NONE) {
> -      mode->haveDepthBuffer = GL_TRUE;
> -      mode->haveStencilBuffer = GL_TRUE;
> -
>        mode->depthBits =
>           util_format_get_component_bits(visual->depth_stencil_format,
>                 UTIL_FORMAT_COLORSPACE_ZS, 0);
>        mode->stencilBits =
>           util_format_get_component_bits(visual->depth_stencil_format,
>                 UTIL_FORMAT_COLORSPACE_ZS, 1);
> +
> +      mode->haveDepthBuffer = mode->depthBits > 0;
> +      mode->haveStencilBuffer = mode->stencilBits > 0;
>     }
>  
>     if (visual->accum_format != PIPE_FORMAT_NONE) {


Looks good.

-Brian