From: Jeff S. <why...@ya...> - 2010-03-14 04:20:43
|
>From: Dan Nicholson <dbn...@gm...> >To: Jeff Smith <why...@ya...> >Cc: Brian Paul <br...@vm...>; David Miller <da...@da...>; "mes...@li..." <mes...@li...> >Sent: Sat, March 13, 2010 2:02:17 PM >Subject: Re: [Mesa3d-dev] xdemos build breakage... > >> If we just use X_{CFLAGS,LIBS}, then we don't have to do the dance >> with X11_{CFLAGS,LIBS} and it will work for manual overrides whether >> people have pkg-config or not. So, I'd suggest changing the first >> argument to PKG_CHECK_MODULES to just X and using X_{CFLAGS,LIBS} >> everywhere else. > >I went ahead and committed the patch with these changes since I needed >it for something else. See 8d86d395dcf6a5f192b6987485bb7aef49f1fefc. Except that AC_PATH_XTRA returns X_LIBS without '-lX11', while PKG_CHECK_MODULES returns X_LIBS with it. In the attached patch I add '-lX11' to the former. Of course, with '-lX11' as part of X_LIBS, the explicit '-lX11' can be removed from the places that use X_LIBS. -- Jeff |