From: Dan N. <dbn...@gm...> - 2010-03-12 16:51:37
|
On Fri, Mar 12, 2010 at 8:13 AM, Brian Paul <br...@vm...> wrote: > Dan Nicholson wrote: >>On Fri, Mar 12, 2010 at 6:48 AM, Jeff Smith <why...@ya...> wrote: >>>> This change: >>>> >>>> commit d888bbc45a84946cafb4f4d2c89681a580cd89bc >>>> Author: Brian Paul <br...@vm...> >>>> Date: Tue Nov 17 13:39:13 2009 -0700 >>>> >>>> progs/xdemos: added -lX11 -lpthread for GNU gold linker >>>> >>>> breaks the build if you are building under a specific path prefix >>>> (say, /opt/XORG) and you have an existing X11 installation in the >>>> usual location (/usr, etc.) >>> >>> I found the same problem and sent a patch to this list a few hours ago to address it: >>> >>> "[PATCH] Add -L$(libdir) for xdemos and egl so that the right libX11 is found" >> >>That's not really the right thing, though. You're assuming that I have >>libX11 in the same libdir as I'm installing to and I want to use it. >>The fact is that configure uses pkg-config to check for x11 and other >>libraries needed to link the demos. It certainly was working before >>without requiring hardcoding things into the Makefiles. > > Oops, I didn't see your reply, Dan. I already committed Jeff's patch. If you have better fix, please revert. No problem. I'll look at it a little later and see if there's more of a general fix from autoconf. I imagine it's not the last time we'll see build breakage in the demos. -- Dan |