Re: [Mesa3d-dev] Mesa (gallium-sampler-view): st/mesa: Associate a sampler view with an st texture object.

[Keith W. <ke...@vm...>]

On Fri, 2010-03-12 at 06:19 -0800, Christoph Bumiller wrote:
> On 12.03.2010 15:08, michal wrote:
> > Keith Whitwell wrote on 2010-03-12 14:46:
> >   
> >> Michal,
> >>
> >> Is the intention to have >1 sampler view active in the Mesa state
> >> tracker, specifically in the cases where min_lod varies?
> >>
> >> In other words, you seem to have two ways of specifying the same state:
> >>
> >>   pipe_sampler_view::first_level
> >>
> >> and
> >>
> >>   pipe_sampler::min_lod
> >>
> >> Is there a case to keep both of these?  Or is one enough?
> >>
> >>   
> >>     
> > It looks like one has to go away, and that would be 
> > pipe_sampler::min_lod. And we want to have a per-texture cache of 
> > sampler views in mesa.
> >
> >   
> But there *is* a difference between
> GL_TEXTURE_MIN_LOD
> and
> GL_TEXTURE_BASE_LEVEL
> which those two seem to reflect.
> 
> How do you implement that if you just remove one ?

Note that we currently only have the one (sampler::min_lod), and the
other is a synonym for the same value that has been introduced by this
branch.

Those GL values are currently both consolidated down by the mesa
state-tracker (along with other stuff) into sampler::min_lod. 

Although Michal has chosen a different name for the new member, it has
the same meaning and the GL semantics can be implemented on top of it as
they currently are for sampler::min_lod.

Keith