Re: [Mesa3d-dev] [PATCH-RFC] st_api, EGLImage, and flush_frontbuffer

[Chia-I Wu <ol...@gm...>]

On Fri, Mar 12, 2010 at 12:07 PM, Jakob Bornecrantz
<wal...@gm...> wrote:
> On Fri, Mar 12, 2010 at 2:12 AM, Chia-I Wu <ol...@gm...> wrote:
>> On Fri, Mar 12, 2010 at 3:11 AM, Jakob Bornecrantz <ja...@vm...> wrote:
>>> Thanks for doing this Chia-I, also a very excellent summary. Last time we
>>> talked about st_api IIRC we both agreed that the way we implemented EGLImage
>>> was wrong. However I think that we have waited long enough to move the state
>>> trackers over to st_api.
>>> Would it to much trouble for you if we didn't do EGLImage in the first
>>> gallium-st-api feature branch? My feeling is that they are two separate
>>> issues and I think we should be able to quickly resolve moving the state
>>> trackers over to st_api and then move on to EGLImage. Looking at the patches
>>> the only affected one is the VG state tracker while the rest should just be
>>> not to apply the EGLImage related patches. I can do this later tonight and
>>> send out a series and give you something to work on.
>>> I really want to move the state trackers over to st_api and I don't want the
>>> EGLImage issues holding us back. I also think that that part of the patch
>>> series looks excellent and I don't foresee any difficulties getting this
>>> merged ASAP.
>>> Again thanks for doing this I know the inter state tracker interactions are
>>> a mess.
>> I've pushed a new branch, gallium-st-api, for the development of st_api.  It
>> consists of this patch series with EGLImage bits stripped out.  I also like to
>> have the branch merged sooner than later.
> Awesome, Thanks!
> The *_iface was always a eye sore in the interface but it could be
> avoided since st_context and st_framebuffer was already taken by the
> gl state tracker. One would have to be crazy to go over the files with
> sed and change all the reference, I guess I'm crazy... I have attached
> three patches does exactly this. Everything compiles between and works
> between each patch but a lot of warnings are generated, but I think I
> squashed them all in the last patch. They should probably be squashed
> if we want to use them, I like to get somebody sensible to weigh in on
> this matter before we do anything with them.
I'd love to see the _iface suffix get dropped too.  About the patches.  st/vega
also defines st_framebuffer and it needs to be renamed.  We might want to have
a convention for data types and variable naming that st/mesa and st/vega could
both follow.

That said, one concern about the renames is that it might cause many conflicts
when the branch is merged.  We might want to delay it until the branch is
merged or about to be merged.

-- 
ol...@Lu...