Re: [Mesa3d-dev] [PATCH] st/vega: Fix OpenVG demo segfaults.

[Zack R. <za...@vm...>]

On Wednesday 03 March 2010 10:51:13 ol...@lu... wrote:
> From: Chia-I Wu <ol...@lu...>
> 
> When the paint is color, paint_bind_samplers binds a dummy sampler
> without a texture.  It causes demos requiring a sampler (those use a
> mask or an image) to crash.
> ---
>  src/gallium/state_trackers/vega/paint.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/src/gallium/state_trackers/vega/paint.c
>  b/src/gallium/state_trackers/vega/paint.c index caf0c14..cdb87d3 100644
> --- a/src/gallium/state_trackers/vega/paint.c
> +++ b/src/gallium/state_trackers/vega/paint.c
> @@ -639,9 +639,6 @@ VGint paint_bind_samplers(struct vg_paint *paint,
>  struct pipe_sampler_state **sa }
>        break;
>     default:
> -      samplers[0] = &paint->pattern.sampler; /* dummy */
> -      textures[0] = 0;
> -      return 0;
>        break;
>     }
>     return 0;
> 

Yea, that's fine. The semantics for which of those need or don't have to be set 
seem to change from release to release, so whatever works currently is ok. I 
didn't have a working vg build since the egl rework ("Error: couldn't get an 
EGL visual config" which I just didn't have time to even look at), so if it 
works for you, feel free to commit.

z