From: Brian P. <br...@vm...> - 2010-03-05 14:48:16
|
Chris Wilson wrote: > Thanks to Intel QA providing a few piglit cases to test the API, this has > had a cursory test and identified the silly cases of using the wrong > lookup functions. > > The ugly part is that I've used 3 different driver functions to handle > each of the 3 object variants - the alternative would be pass in a void > pointer and a type id. If we acquire more distinct object types, then > multiplexing a single driver function would be preferable to adding > multiple stubs. > > Please review and include in 7.7! :) This will go into Mesa 7.8, actually. I see patches 1/4, 3/4 and 4/4 but not 2/4. Are the patches misnumbered or did 2/4 not get posted? Can you commit these, Chris? Are the new piglit tests going into the fd.o repository? I don't see them yet. -Brian |