Re: [Mesa3d-dev] Mesa (master): mesa: Fix unsigned comparison.

[Vinson L. <vl...@vm...>]

Michel, thanks for spotting this.

I've reverted the bad commit. Please go ahead and submit your correct fix.

________________________________________
From: Michel Dänzer [mi...@da...]
Sent: Thursday, March 04, 2010 1:41 AM
To: Vinson Lee
Cc: mes...@li...
Subject: Re: Mesa (master): mesa: Fix unsigned comparison.

On Thu, 2010-03-04 at 01:27 -0800, Vinson Lee wrote:
> Module: Mesa
> Branch: master
> Commit: f9504e75f02586a8561733e0e2711c65efa2979d
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f9504e75f02586a8561733e0e2711c65efa2979d
>
> Author: Vinson Lee <vl...@vm...>
> Date:   Thu Mar  4 01:24:44 2010 -0800
>
> mesa: Fix unsigned comparison.
>
> ---
>
>  src/mesa/main/api_validate.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c
> index 326ad6f..80bc826 100644
> --- a/src/mesa/main/api_validate.c
> +++ b/src/mesa/main/api_validate.c
> @@ -147,7 +147,7 @@ check_index_bounds(GLcontext *ctx, GLsizei count, GLenum type,
>
>     vbo_get_minmax_index(ctx, &prim, &ib, &min, &max);
>
> -   if (min + basevertex < 0 ||
> +   if (min < basevertex ||

That's not equivalent, is it? Something like

   if ((basevertex < 0 && min < -basevertex) ||

should be.


--
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer