Re: [Mesa3d-dev] RFC: gallium-format-cleanup branch (was Gallium format swizzles)

[José F. <jfo...@vm...>]

Consistency between different formats is not always a good metric here, as there are all sort of historical reasons which make the used set of formats out of all possible quite asymmetric.

PIPE_FORMAT_X8B8G8R8_UNORM is being used by mesa. PIPE_FORMAT_R8G8B8X8_UNORM doesn't exist hence it appears to be unnecessary. So it doesn't make sense to rename.

But I think you stumbled on something: PIPE_FORMAT_R8G8B8X8_SNORM might not be needed. It's not used anywhere, nor can I find mention of such format in D3D9/10. I'll remove it if nobody opposes.

Jose
________________________________________
From: Luca Barbieri [luc...@gm...]
Sent: Tuesday, March 02, 2010 22:16
To: Jose Fonseca
Cc: mes...@li...
Subject: Re: [Mesa3d-dev] RFC: gallium-format-cleanup branch (was Gallium       format swizzles)

Shouldn't
PIPE_FORMAT_X8B8G8R8_UNORM        = 68,

be instead R8G8B8X8_UNORM, which is currently missing, for consistency with:
PIPE_FORMAT_R8G8B8X8_SNORM        = 81,

with X8B8G8R8_UNORM perhaps put at the end next to PIPE_FORMAT_A8B8G8R8_UNORM?