Re: [Mesa3d-dev] Remove color index rendering?

[Brian P. <bri...@gm...>]

On Fri, Feb 26, 2010 at 7:19 PM, Ian Romanick <id...@fr...> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Ian Romanick wrote:
>> While we're on the topic of removing dead weight, can we remove support
>> for color index rendering?  None of the hardware drivers support color
>> index rendering, and color index rendering is deprecated in OpenGL 3.0
>> (and removed in 3.1).
>>
>> Can it please die in a fire?
>
> I have just pushed a branch that removes color-index rendering.  It is
> available for review in the remove_ci_rendering branch of
> git://anongit.freedesktop.org/~idr/mesa.git.  I have done on minimal
> testing so far, but I intend to do more over the weekend.  It took most
> of the week just to get all the changes made.
>
> There are 38 individual patches.  The patches remove a total of 2,304
> lines of code.  I tried to make it easier to review by keeping the
> individual changes small.
>
> There are probably some additional changes that could be made.  There is
> still a bit of index tracking in TNL and other related places.  I think
> some of this can be removed.  Such removals would be more invasive (grep
> for MAT_*_INDEX),

I think you mean the MAT_INDEX_* tokens there.  We can weed out some
of that little stuff over time.


> and may impact our adherence to the spec.  For
> example, some queries would return incorrect values.
>
> In any case, I'm satisfied with this set of removals for now.

The branch looks good.  Just one minor thing: please document CI
removal in the 7.8 release notes file.

-Brian