Re: [Mesa3d-dev] [PATCH] st/dri: don't enable EXT_draw_buffers2 by default

[Marek O. <ma...@gm...>]

On Tue, Feb 23, 2010 at 2:49 AM, Marek Olšák <ma...@gm...> wrote:

> On Mon, Feb 22, 2010 at 4:23 PM, Brian Paul <bri...@gm...>wrote:
>
>> On Sun, Feb 21, 2010 at 8:00 AM, Marek Olšák <ma...@gm...> wrote:
>> > Hi,
>> >
>> > the attached patch modifies st/dri to not enable EXT_draw_buffers2 by
>> > default because r300g and most probably even some other drivers can't
>> > support this extension. The drivers reporting support of
>> > PIPE_CAP_INDEP_BLEND_ENABLE are not affected by this patch.
>> >
>> > Please review.
>>
>> Hmm, I believe the extensions listed in dri_extensions.c are those
>> that _may_ be supported by drivers.  But its the st_extensions.c code
>> that queries the driver for various caps (such as
>> PIPE_CAP_INDEP_BLEND_ENABLE) and then turns on the extension if
>> applicable.
>>
>
> I stand corrected.
>
>
I was actually right the first time. The list in dri_extensions.c is being
advertised *regardless* of what a driver reports (tested and debugged). None
of the extensions on the list can be disabled using pipe_screen::get_param,
making the majority of feature caps useless. However, I can enable/disable
any extension which is *not* on the list using appropriate caps (if they
exist).

-Marek