Re: [Mesa3d-dev] softpipe/llvmpipe SConscript

[José F. <jfo...@vm...>]

On Tue, 2010-02-23 at 13:09 -0800, Xavier Chantry wrote:
> On Tue, Feb 23, 2010 at 10:18 AM, José Fonseca <jfo...@vm...> wrote:
> > But there is another thing that we can do: take out trace from the scons
> > options and always built it, as there are so many state trackers and
> > winsys that rely on it for debug building, and trace can really build
> > anywhere and is thin so there's no point is making it an option.
> >
> 
> I like this a lot, see attached patch.
> This is my first time editing scons files so I hope I got it right.
> 
> >> A side question :
> >> line 21 : if not set(('softpipe', 'llvmpipe',
> >> 'trace')).intersection(env['drivers']):
> >>     print 'warning: no supported pipe driver: skipping build of xlib libGL.so'
> >>     Return()
> >>
> >> But below in the script (line 41-58), the drivers used are softpipe ,
> >> llvmpipe and cell.
> >> Should trace be replaced by cell in the above check ?
> >
> > Yes, I think so.
> >
> 
> Also changed in attached patch.

Thanks. Commited, with just a change: I still allow drivers=trace to
avoid breaking all build infrastructure that's already using that
option. I'll eventually remove the option once I've updated everywhere
not to use it.

Jose