From: Brian P. <bri...@gm...> - 2010-02-22 15:54:22
|
On Sat, Feb 20, 2010 at 9:32 AM, Xavier Chantry <cha...@gm...> wrote: > On Sat, Feb 20, 2010 at 5:22 PM, Brian Paul <bri...@gm...> wrote: >> On Fri, Feb 19, 2010 at 7:34 PM, Xavier Chantry >> <cha...@gm...> wrote: >>> It seems the commit below will always report an user error when >>> glxinfo -l is called. >>> And indeed I always get the following : >>> $ glxinfo -l >>> ... >>> GL_VERTEX_PROGRAM_ARB: >>> ... >>> Mesa: User error: GL_INVALID_ENUM in glGetProgramivARB(pname) >>> Mesa: User error: GL_INVALID_ENUM in glGetProgramivARB(pname) >>> Mesa: User error: GL_INVALID_ENUM in glGetProgramivARB(pname) >>> Mesa: User error: GL_INVALID_ENUM in glGetProgramivARB(pname) >>> Mesa: User error: GL_INVALID_ENUM in glGetProgramivARB(pname) >>> Mesa: User error: GL_INVALID_ENUM in glGetProgramivARB(pname) >>> >>> Should glxinfo be fixed to avoid this error ? >>> We could just put the fragment program only parameter in its own list, >>> and not use them when target is vertex program. >> >> Well, normally GL errors aren't reported to stderr so most people >> running non-debug builds won't see those. But yeah, we probably >> shouldn't generate the errors anyway. Feel free to write a patch to >> glxinfo... >> > > I only realized yesterday that non-debug was the reason other people > (and some of my systems) didn't show these errors. It had been bugging > me for a while :) > > Attached patch should fix it. Thanks. I'll commit it soon. -Brian |