[Mesa3d-dev] [PATCH] util: fix swizzles in the format table for 8-bits-per-channel formats

[Marek O. <ma...@gm...>]

Hi José,

the attached patch fixes incorrect swizzles in u_format.csv. There are
basically just 2 drivers which depend on the swizzles in this table:
llvmpipe and r300g. Since r300g started supporting pretty much every texture
format except SCALED ones, a few regressions have showed up. This patch
resolves all issues I had, especially with the SRGB formats but I decided to
clean it up all. git log:

    util: fix swizzles in the format table for 8-bits-per-channel formats

    The 8-bits-per-channel formats having the same channel order had
completely
    different swizzles, and at the same time, the same swizzles were used
for
    completely different channel orders of 8bpc formats.

    This made the whole table self-contradicting, caused headaches, and last
    but not least, incorrent rendering for the drivers relying on these
swizzles.

I hope I got it right. I didn't make a special distinction between the array
and arith layouts. All I did was to make sure that if I grep e.g. A8R8G8B8,
I'll get the same swizzles and not entirely different ones.

Please review.

Best regards

Marek