From: Keith W. <kei...@go...> - 2010-02-08 14:05:06
|
On Fri, Feb 5, 2010 at 4:47 PM, Jesse Barnes <jb...@vi...> wrote: > On Fri, 5 Feb 2010 10:08:44 +0000 > Keith Whitwell <kei...@go...> wrote: > >> Jesse, >> >> Can you take a look at the attached patch? I'd really like to be able >> to build mesa and the DRI drivers on current distros (eg Ubuntu 9.10) >> without having to pull in heaps of dependencies. The patch adds >> #ifdefs to protect against the newer DRI2 protocol changes, meaning I >> can build-test linux-dri and related targets with just the >> distro-supplied packages. > > As much as I hate #ifdefs, I think this is probably a reasonable thing > to do. Have you tested to confirm that it preserves both the old and > new behavior when different proto headers are present? > As far as I can tell, it does. In particular, with the new headers, mesa builds the same libglapi.a with/without the patch. I've committed it now, please let me know if there are any regressions. Keith |