Re: [Mesa3d-dev] [xserver patch 1/6] Add a PreConfigureWindow hook.

[Francisco J. <cur...@ri...>]

Michel Dänzer <mi...@da...> writes:

> On Sat, 2010-01-16 at 23:00 +0100, Francisco Jerez wrote: 
>> Executed from the ConfigureWindow request, right before sending
>> ConfigureNotify to the clients.
>> 
>> This commit breaks the ScreenRec ABI.
>> 
>> Signed-off-by: Francisco Jerez <cur...@ri...>
>> ---
>> It might be possible to delay the ABI bump, but I'd rather do it this
>> way. The already existing Resize and MoveWindow hooks aren't an option
>> because the client *needs* to get DRI2InvalidateBuffers before
>> ConfigureNotify.
>
> 'Needs to' why? If you're worrying about the client side driver being
> unable to see the DRI2InvalidateBuffers event for the client app's
> reaction to the ConfigureNotify event, how likely is that to happen, and
> couldn't it be avoided by other means?
>
Right, that's what I was worried about. It's unlikely, but possible if
e.g. the X server output buffer is flushed between both events. I think
it could also be done hooking an "event callback" as (IIRC) the record
extension used to do, but... it would be slow and ugly.

> If the ABI break is truly unavoidable, it would have been nice to get it
> into xserver 1.8, which already bumped the ABI versions...