Re: [Mesa3d-dev] Problem with commit acae6f06 "dri: fix crash in driGetConfigAttribIndex"

[Stefan B. <Ste...@no...>]

Hi,

ext Kristian Høgsberg wrote:
> On Tue, 2008-08-26 at 12:43 +0100, Dave Airlie wrote:
>>> the following commit
>>>
>>>     1724334d7c82abe55b6506dfe369df4facae6f06
>>>
>>>     dri: fix crash in driGetConfigAttribIndex
>>>
>>>     Accessing a GLboolean via an int pointer on big-endian == bad.
>>>
>>> breaks 3D stuff on my radeon r5xx card: GLX no longer reports visuals with
>>> double buffering. I've attached the different outputs from glxinfo:
>> I'm going to back this out, but it would be nice to fix properly, krh any 
>> ideas?
> 
> Hmm, not sure why DaveM's patch would break that for you, but I've just
> committed a different fix.  We never sent the floatMode attribute over
> the wire anyway so I just took it out.  If it's still broken, something
> else must be wrong on your side - let me know.

Errrmm *blushes* *mumbles mea culpa*


Your commit made me realize that Dave's mesa commit was accompanied by a 
corresponding commit to the xserver. My xserver was still at 1.4.99.905 
but the commit is post 1.4.99.906 in the server-1.5-branch. I've now 
recompiled my .905 source with Dave's commit included and everything is 
fine again. Sorry for the mess...


I'll also compile the latest xserver git to verify that your change 
works too.

Regards,

	Stefan

---
Stefan Becker
E-Mail: Ste...@no...