Re: [Mesa3d-dev] comments on r300_fragprog.c commit

[Brian P. <bri...@tu...>]

Oliver McFadden wrote:
> I committed the _mesa_alloc_instructions/_mesa_init_instructions 
> changes. Please
> let me know if I've broken anything here. I believe it's perfectly fine, 
> though.

Looks like a _mesa_copy_instructions() function would be a nice helper 
too, rather than memcpy().  Feel free to do that.

Or better yet, a _mesa_insert_instructions() function could realloc a 
list of instructions, making space for N new ones at a specific point, 
initializing the new instructions too.


> insert_wpos in r300_vertexprog.c could use some improvement though. I'm 
> not sure
> if it's best to memcpy the END instruction too, or explicitly specify 
> it, eg:
>     vpi[i].Opcode = OPCODE_END;

I think either way is OK, though with _mesa_insert_instructions() you 
could forget about it.


> Btw, would anyone have a problem renaming r300_vertexprog.c to 
> r300_vertprog.c;
> this is the name everyone else uses and it's shorter, too. :)

OK by me.

-Brian