Re: [Mesa3d-dev] [Mesa3d-cvs] CVS Update: Mesa (branch: trunk)

[Keith W. <ke...@tu...>]

Michel D=E4nzer wrote:
> On Fri, 2006-09-22 at 19:23 +0200, Michel D=C3=A4nzer wrote:
>> On Fri, 2006-09-22 at 14:06 +0100, Keith Whitwell wrote:
>>> Michel D=C3=A4nzer wrote:
>>>> On Fri, 2006-09-22 at 11:14 +0100, Keith Whitwell wrote:
>>>>> Maybe enable for the paths that are well understood and tested, but=
=20
>>>>> where it is still behaving contrary to expectations, leave it disab=
led.=20
>>>>>     I'd say it is behaving as expected in the software mesa cases a=
nd=20
>>>>> argb8888.
>>>> Our confusion might have to do with the fact I now discovered that t=
he
>>>> hardware drivers only hit argb8888 and a8. :} Software Mesa also hit=
s
>>>> rgb and rgba8888, which the attached patch fixes, so I think all the=
se
>>>> make sense now. *phew*
>>> So, it looks like all that needs to be done is to extend the same log=
ic=20
>>> to the bgr888 and rgb888 formats, ie add a test on littleEndian and=20
>>> adjust the dstMap in each case?
>> No, these seem to be byte streams. I meant to say 'rgb888' instead of
>> just 'rgb' above, i.e. software Mesa passes glean with this patch for
>> non-half-floats.
>=20
> Keith, are you okay with me committing this?
>=20

Yes, go ahead.

Keith