Chia-I Wu wrote:
> On Mon, Apr 5, 2010 at 7:42 AM, Dave Airlie <ai...@gm...> wrote:
>> Starting program: /home/airlied/mesa/progs/demos/readpix
>> [Thread debugging using libthread_db enabled]
>> GL_VERSION = 2.1 Mesa 7.9-devel
>> GL_RENDERER = Gallium 0.4 on RV530
>>
>> Program received signal SIGSEGV, Segmentation fault.
>> 0xb7cc13dd in _mesa_get_color_read_type (ctx=0x8086e38)
>> at main/framebuffer.c:1021
>> 1021 }
>> Missing separate debuginfos, use: debuginfo-install
>> expat-2.0.1-8.fc12.i686 libICE-1.0.6-1.fc12.i686
>> libSM-1.1.0-7.fc12.i686 libX11-1.3-1.fc12.i686
>> libXdamage-1.1.2-1.fc12.i686 libXext-1.1-2.fc12.i686
>> libXfixes-4.0.4-1.fc12.i686 libXi-1.3-2.fc12.i686
>> libXmu-1.0.5-1.fc12.i686 libXt-1.0.7-1.fc12.i686
>> libXxf86vm-1.1.0-1.fc12.i686 libgcc-4.4.3-4.fc12.i686
>> libstdc++-4.4.3-4.fc12.i686 libuuid-2.16.2-5.fc12.i686
>> libxcb-1.5-1.fc12.i686
>> (gdb) bt
>> #0 0xb7cc13dd in _mesa_get_color_read_type (ctx=0x8086e38)
>> at main/framebuffer.c:1021
>> #1 0xb7d75758 in _mesa_GetIntegerv (pname=35738, params=0x804c41c)
>> at main/get.c:5576
>> #2 0x080493ae in Init (argc=1, argv=0xbffff2b4) at readpix.c:354
>> #3 main (argc=1, argv=0xbffff2b4) at readpix.c:396
>> (gdb)
> I have the segfault with i915g and non-gallium fakeglx. It seems _mesa_Get*
> should also validate the states before getting these state variables
>
> - GL_IMPLEMENTATION_COLOR_READ_TYPE_OES
> - GL_IMPLEMENTATION_COLOR_READ_FORMAT_OES
Yeah, that's it. I'll commit a fix.
-Brian
|