Menu
▾
▴
mesa3d-dev
|
From: RALOVICH, K. <kri...@gm...> - 2010-03-24 02:10:17
Attachments:
0001-demos-import-GLSL-raytracing-demos.patch
|
Attached patch adds to glsl demos to mesa. If the drivers support them, these might give better performance numbers than glxgears. Currently both works fine with swrast, but neither works on i965. Corresponding active bug reports: https://bugs.freedesktop.org/show_bug.cgi?id=26691 https://bugs.freedesktop.org/show_bug.cgi?id=27060 Please apply! Thanks, Kristof |
|
From: Brian P. <br...@vm...> - 2010-03-24 15:04:49
|
RALOVICH wrote: > Attached patch adds to glsl demos to mesa. If the drivers support > them, these might give better performance numbers than glxgears. > > Currently both works fine with swrast, but neither works on i965. > > Corresponding active bug reports: > https://bugs.freedesktop.org/show_bug.cgi?id=26691 > https://bugs.freedesktop.org/show_bug.cgi?id=27060 > > Please apply! Done, with minor fixes. Thanks! -Brian |
|
From: RALOVICH, K. <kri...@gm...> - 2010-03-24 15:11:18
|
Brian, that was fast! Who do you think I should bug, to get these working on i965? Also as my time allows, I am planning to extend them with mouse input for orientation and arrow keys for moving to camera to become more interactive. Thanks, Kristof On Wed, Mar 24, 2010 at 11:04, Brian Paul <br...@vm...> wrote: > RALOVICH wrote: >> >> Attached patch adds to glsl demos to mesa. If the drivers support >> them, these might give better performance numbers than glxgears. >> >> Currently both works fine with swrast, but neither works on i965. >> >> Corresponding active bug reports: >> https://bugs.freedesktop.org/show_bug.cgi?id=26691 >> https://bugs.freedesktop.org/show_bug.cgi?id=27060 >> >> Please apply! > > Done, with minor fixes. Thanks! > > -Brian > > |
|
From: Brian P. <br...@vm...> - 2010-03-24 15:15:36
|
RALOVICH wrote: > Brian, > > that was fast! Who do you think I should bug, to get these working on i965? Eric Anholt has been working on the i965 driver. I wouldn't bug him too much though. He's pretty busy. > Also as my time allows, I am planning to extend them with mouse input > for orientation and arrow keys for moving to camera to become more > interactive. OK, ignore my other msg then. -Brian > > Thanks, > Kristof > > > > On Wed, Mar 24, 2010 at 11:04, Brian Paul <br...@vm...> wrote: >> RALOVICH wrote: >>> Attached patch adds to glsl demos to mesa. If the drivers support >>> them, these might give better performance numbers than glxgears. >>> >>> Currently both works fine with swrast, but neither works on i965. >>> >>> Corresponding active bug reports: >>> https://bugs.freedesktop.org/show_bug.cgi?id=26691 >>> https://bugs.freedesktop.org/show_bug.cgi?id=27060 >>> >>> Please apply! >> Done, with minor fixes. Thanks! >> >> -Brian >> >> |
|
From: Ian R. <id...@fr...> - 2010-03-24 17:54:10
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 RALOVICH wrote: > Brian, > > that was fast! Who do you think I should bug, to get these working on i965? As always, if you find a bug, submit a bug report: http://intellinuxgraphics.org/how_to_report_bug.html Anything else will get lost and / or forgotten. > Also as my time allows, I am planning to extend them with mouse input > for orientation and arrow keys for moving to camera to become more > interactive. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkuqUWwACgkQX1gOwKyEAw/CzwCfYLs2tg4tQ74xD1LScZ3QP6NE /goAn2kzMPsZC7gXIIl+amfzkMJ6MN0m =p5Ud -----END PGP SIGNATURE----- |
|
From: RALOVICH, K. <kri...@gm...> - 2010-03-24 17:57:57
|
On Wed, Mar 24, 2010 at 13:52, Ian Romanick <id...@fr...> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > RALOVICH wrote: >> Brian, >> >> that was fast! Who do you think I should bug, to get these working on i965? > > As always, if you find a bug, submit a bug report: > > http://intellinuxgraphics.org/how_to_report_bug.html > > Anything else will get lost and / or forgotten. My first mail lists the active bug reports I opened for these. Please refer to that e-mail. Kristof > >> Also as my time allows, I am planning to extend them with mouse input >> for orientation and arrow keys for moving to camera to become more >> interactive. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.10 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iEYEARECAAYFAkuqUWwACgkQX1gOwKyEAw/CzwCfYLs2tg4tQ74xD1LScZ3QP6NE > /goAn2kzMPsZC7gXIIl+amfzkMJ6MN0m > =p5Ud > -----END PGP SIGNATURE----- > |
|
From: Eric A. <er...@an...> - 2010-03-24 20:46:51
|
On Wed, 24 Mar 2010 11:10:47 -0400, RALOVICH, Kristóf <kri...@gm...> wrote: > Brian, > > that was fast! Who do you think I should bug, to get these working on i965? > > Also as my time allows, I am planning to extend them with mouse input > for orientation and arrow keys for moving to camera to become more > interactive. Make a testcase for piglit, and I'd love to fix your bug. |
|
From: RALOVICH, K. <kri...@gm...> - 2010-03-28 21:52:42
Attachments:
0001-import-glsl-raytracing-tests.patch
|
Eric, please see the attached patch for piglit. The patch includes 2 new tests based on the demos I provided for mesa. Let me know if I can further help! Thanks, Kristof On Wed, Mar 24, 2010 at 16:33, Eric Anholt <er...@an...> wrote: > On Wed, 24 Mar 2010 11:10:47 -0400, RALOVICH, Kristóf <kri...@gm...> wrote: >> Brian, >> >> that was fast! Who do you think I should bug, to get these working on i965? >> >> Also as my time allows, I am planning to extend them with mouse input >> for orientation and arrow keys for moving to camera to become more >> interactive. > > Make a testcase for piglit, and I'd love to fix your bug. > |
|
From: RALOVICH, K. <kri...@gm...> - 2010-04-14 17:15:06
Attachments:
0001-import-glsl-raytracing-tests.patch
|
Would someone please have a look at this piglit tests? Thanks, Kristof On Sun, Mar 28, 2010 at 17:52, RALOVICH, Kristóf <kri...@gm...> wrote: > Eric, > > please see the attached patch for piglit. The patch includes 2 new > tests based on the demos I provided for mesa. > > Let me know if I can further help! > > Thanks, > Kristof > > On Wed, Mar 24, 2010 at 16:33, Eric Anholt <er...@an...> wrote: >> On Wed, 24 Mar 2010 11:10:47 -0400, RALOVICH, Kristóf <kri...@gm...> wrote: >>> Brian, >>> >>> that was fast! Who do you think I should bug, to get these working on i965? >>> >>> Also as my time allows, I am planning to extend them with mouse input >>> for orientation and arrow keys for moving to camera to become more >>> interactive. >> >> Make a testcase for piglit, and I'd love to fix your bug. >> > |
|
From: Brian P. <br...@vm...> - 2010-04-14 20:49:28
|
It looks like the piglit tests use an image comparison to determine pass/fail, right? That may not be too reliable since different drivers will produce slightly different results. Is there any way that the rendering can be checked for correctness without relying on an exact image comparison? -Brian RALOVICH, Kristóf wrote: > Would someone please have a look at this piglit tests? > > Thanks, > Kristof > > On Sun, Mar 28, 2010 at 17:52, RALOVICH, Kristóf > <kri...@gm...> wrote: >> Eric, >> >> please see the attached patch for piglit. The patch includes 2 new >> tests based on the demos I provided for mesa. >> >> Let me know if I can further help! >> >> Thanks, >> Kristof >> >> On Wed, Mar 24, 2010 at 16:33, Eric Anholt <er...@an...> wrote: >>> On Wed, 24 Mar 2010 11:10:47 -0400, RALOVICH, Kristóf <kri...@gm...> wrote: >>>> Brian, >>>> >>>> that was fast! Who do you think I should bug, to get these working on i965? >>>> >>>> Also as my time allows, I am planning to extend them with mouse input >>>> for orientation and arrow keys for moving to camera to become more >>>> interactive. >>> Make a testcase for piglit, and I'd love to fix your bug. >>> |
|
From: RALOVICH, K. <kri...@gm...> - 2010-04-14 21:02:31
|
Brian, you are right, maybe more freedom should be allowed, but piglit_probe_pixel_rgb() already uses 0.01 as threshold which should be enough if the ray directions do not have large FP differences. As a short term goal with the test vsraytrace was, that it should not take my GM4500 down. As a longer term solution we can allow e.g. 15% of pixels to even fail piglit_probe_pixel_rgb() too. I can extend the patch with this if you'd like it. Kristof On Wed, Apr 14, 2010 at 16:49, Brian Paul <br...@vm...> wrote: > It looks like the piglit tests use an image comparison to determine > pass/fail, right? > > That may not be too reliable since different drivers will produce slightly > different results. > > Is there any way that the rendering can be checked for correctness without > relying on an exact image comparison? > > -Brian > > > RALOVICH, Kristóf wrote: >> >> Would someone please have a look at this piglit tests? >> >> Thanks, >> Kristof >> >> On Sun, Mar 28, 2010 at 17:52, RALOVICH, Kristóf >> <kri...@gm...> wrote: >>> >>> Eric, >>> >>> please see the attached patch for piglit. The patch includes 2 new >>> tests based on the demos I provided for mesa. >>> >>> Let me know if I can further help! >>> >>> Thanks, >>> Kristof >>> >>> On Wed, Mar 24, 2010 at 16:33, Eric Anholt <er...@an...> wrote: >>>> >>>> On Wed, 24 Mar 2010 11:10:47 -0400, RALOVICH, Kristóf >>>> <kri...@gm...> wrote: >>>>> >>>>> Brian, >>>>> >>>>> that was fast! Who do you think I should bug, to get these working on >>>>> i965? >>>>> >>>>> Also as my time allows, I am planning to extend them with mouse input >>>>> for orientation and arrow keys for moving to camera to become more >>>>> interactive. >>>> >>>> Make a testcase for piglit, and I'd love to fix your bug. >>>> > > |
|
From: Brian P. <br...@vm...> - 2010-04-14 21:14:05
|
Suppose a ray just barely hits/misses a sphere. Depending on the GPU arithmetic and whether the outcome is a hit or miss, the resulting pixel color could be completely different. A per-pixel error margin won't account for this. But as you suggested, if you allow a certain number or percent of pixel comparisons to fail, that might do the job here. How about implementing that? I'd also suggest putting the comparison code into a new piglit utility function (or at least put the code in a separate function that could be promoted to piglit-util.c someday). BTW, the piglit_probe_pixel_rgb() function should really take a tolerance parameter, rather than it being hard-coded inside the function. Another piglit utility function to compute tolerances from various parameters would be good... but that's another project. -Brian RALOVICH, Kristóf wrote: > Brian, > > you are right, maybe more freedom should be allowed, but > piglit_probe_pixel_rgb() already uses 0.01 as threshold which should > be enough if the ray directions do not have large FP differences. > > As a short term goal with the test vsraytrace was, that it should not > take my GM4500 down. > > As a longer term solution we can allow e.g. 15% of pixels to even fail > piglit_probe_pixel_rgb() too. I can extend the patch with this if > you'd like it. > > Kristof > > On Wed, Apr 14, 2010 at 16:49, Brian Paul <br...@vm...> wrote: >> It looks like the piglit tests use an image comparison to determine >> pass/fail, right? >> >> That may not be too reliable since different drivers will produce slightly >> different results. >> >> Is there any way that the rendering can be checked for correctness without >> relying on an exact image comparison? >> >> -Brian >> >> >> RALOVICH, Kristóf wrote: >>> Would someone please have a look at this piglit tests? >>> >>> Thanks, >>> Kristof >>> >>> On Sun, Mar 28, 2010 at 17:52, RALOVICH, Kristóf >>> <kri...@gm...> wrote: >>>> Eric, >>>> >>>> please see the attached patch for piglit. The patch includes 2 new >>>> tests based on the demos I provided for mesa. >>>> >>>> Let me know if I can further help! >>>> >>>> Thanks, >>>> Kristof >>>> >>>> On Wed, Mar 24, 2010 at 16:33, Eric Anholt <er...@an...> wrote: >>>>> On Wed, 24 Mar 2010 11:10:47 -0400, RALOVICH, Kristóf >>>>> <kri...@gm...> wrote: >>>>>> Brian, >>>>>> >>>>>> that was fast! Who do you think I should bug, to get these working on >>>>>> i965? >>>>>> >>>>>> Also as my time allows, I am planning to extend them with mouse input >>>>>> for orientation and arrow keys for moving to camera to become more >>>>>> interactive. >>>>> Make a testcase for piglit, and I'd love to fix your bug. >>>>> >> |
|
From: Eric A. <er...@an...> - 2010-04-14 21:49:12
|
On Sun, 28 Mar 2010 17:52:16 -0400, RALOVICH, Kristóf <kri...@gm...> wrote: > Eric, > > please see the attached patch for piglit. The patch includes 2 new > tests based on the demos I provided for mesa. > > Let me know if I can further help! The main thing I'm concerned about is that you seem to be looking for pixel-precise results. Do you expect that from this code? Generally in piglit we try to construct some environment that gets a few consistent results and probe a few representative pixels out of it. Beyond that, since you didn't use git send-email, the patch came out mangled and I couldn't apply it to try it out. |
|
From: RALOVICH, K. <kri...@gm...> - 2010-04-14 23:00:02
|
On Wed, Apr 14, 2010 at 17:49, Eric Anholt <er...@an...> wrote: > On Sun, 28 Mar 2010 17:52:16 -0400, RALOVICH, Kristóf <kri...@gm...> wrote: >> Eric, >> >> please see the attached patch for piglit. The patch includes 2 new >> tests based on the demos I provided for mesa. >> >> Let me know if I can further help! > > The main thing I'm concerned about is that you seem to be looking for > pixel-precise results. Do you expect that from this code? Generally in > piglit we try to construct some environment that gets a few consistent > results and probe a few representative pixels out of it. I'll update the patch based on Brian's conclusion to address this. > > Beyond that, since you didn't use git send-email, the patch came out > mangled and I couldn't apply it to try it out. > The patch is actually an attachment to the email. Try saving it as that, not copy-pasting from the email's text. Kristof |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X