mesa3d-dev

[Mesa3d-dev] mesa 7.8 GIT: Broken by "glapi: Correctly generate static disatches for X86."

[Sedat D. <sed...@go...>]

Hi,

while upgrading my mesa from 7.8 GIT branch, I saw with

commit 41a87a43e11c664935349f938022d58d3e22da4e
"glapi: Correctly generate static disatches for X86."

the build breaking (especially with xdemos).

- Sedat -

[build.log]
....
ccache gcc -I../../include  -g -O2 -Wall -Wmissing-prototypes -std=c99
-ffast-math -fvisibility=hidden -fno-strict-aliasing -g  -fPIC
-DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM
-D_GNU_SOURCE -DPTHREADS -DDEBUG -DHAVE_POSIX_MEMALIGN -DGLX_USE_TLS
-DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER
-DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -DHAVE_ALIAS
glxdemo.c -L../../lib -lGL -L/usr/lib  -lm -lX11 -lpthread -o glxdemo
../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
collect2: ld returned 1 exit status
make[2]: *** [glsync] Error 1
make[2]: *** Waiting for unfinished jobs....
../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'

../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
collect2: ld returned 1 exit status
make[2]: *** [glxdemo] Error 1
../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
collect2: ld returned 1 exit status
make[2]: *** [glthreads] Error 1
make[2]: Leaving directory `/home/sd/src/mesa/mesa/progs/xdemos'
make[1]: *** [subdirs] Error 1
make[1]: Leaving directory `/home/sd/src/mesa/mesa/progs'
make: *** [default] Error 1

Re: [Mesa3d-dev] mesa 7.8 GIT: Broken by "glapi: Correctly generate static disatches for X86."

[Sedat D. <sed...@go...>]

My autogen.sh line looks like this:

$ ./autogen.sh --prefix=/usr --with-driver=dri
--with-dri-driverdir=/usr/lib/dri --with-dri-drivers=r300,swrast
--enable-gallium-radeon --with-state-trackers=dri,glx --enable-glx-tls
--enable-debug

- Sedat -

On Sat, Mar 20, 2010 at 2:51 PM, Sedat Dilek <sed...@go...> wrote:
> Hi,
>
> while upgrading my mesa from 7.8 GIT branch, I saw with
>
> commit 41a87a43e11c664935349f938022d58d3e22da4e
> "glapi: Correctly generate static disatches for X86."
>
> the build breaking (especially with xdemos).
>
> - Sedat -
>
> [build.log]
> ....
> ccache gcc -I../../include  -g -O2 -Wall -Wmissing-prototypes -std=c99
> -ffast-math -fvisibility=hidden -fno-strict-aliasing -g  -fPIC
> -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM
> -D_GNU_SOURCE -DPTHREADS -DDEBUG -DHAVE_POSIX_MEMALIGN -DGLX_USE_TLS
> -DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER
> -DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -DHAVE_ALIAS
> glxdemo.c -L../../lib -lGL -L/usr/lib  -lm -lX11 -lpthread -o glxdemo
> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
> collect2: ld returned 1 exit status
> make[2]: *** [glsync] Error 1
> make[2]: *** Waiting for unfinished jobs....
> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
>
> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
> collect2: ld returned 1 exit status
> make[2]: *** [glxdemo] Error 1
> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
> collect2: ld returned 1 exit status
> make[2]: *** [glthreads] Error 1
> make[2]: Leaving directory `/home/sd/src/mesa/mesa/progs/xdemos'
> make[1]: *** [subdirs] Error 1
> make[1]: Leaving directory `/home/sd/src/mesa/mesa/progs'
> make: *** [default] Error 1
>

Re: [Mesa3d-dev] mesa 7.8 GIT: Broken by "glapi: Correctly generate static disatches for X86."

[Sedat D. <sed...@go...>]

Hmm, strange...

$ cd ~/src/mesa/mesa/progs/xdemos/

$ gcc -g -O2 -Wall -Wmissing-prototypes -std=c99 -ffast-math
-fvisibility=hidden -fno-strict-aliasing -g  -fPIC  -DUSE_X86_ASM
-DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM -D_GNU_SOURCE -DPTHREADS
-DDEBUG -DHAVE_POSIX_MEMALIGN -DGLX_USE_TLS -DPTHREADS
-DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER -DGLX_DIRECT_RENDERING
-DGLX_INDIRECT_RENDERING -DHAVE_ALIAS  corender.o ipc.o -L../../lib
-lGL -L/usr/lib  -lm -lX11 -lpthread -o corender
../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
collect2: ld returned 1 exit status

$ undefref="glBlitFramebufferEXT glDeleteVertexArraysAPPLE
glIsVertexArrayAPPLE glBlendEquationSeparateEXT"

$ for i in $undefref ; do objdump -x ../../lib/libGL.so | grep $i ; done
0001b000 l     F .text	000000a0              __indirect_glBlitFramebufferEXT
00000000         *UND*	00000000              glBlitFramebufferEXT
00000000         *UND*	00000000              glDeleteVertexArraysAPPLE
00000000         *UND*	00000000              glIsVertexArrayAPPLE
0001b570 l     F .text	00000058
__indirect_glBlendEquationSeparateEXT
00000000         *UND*	00000000              glBlendEquationSeparateEXT

- Sedat -

On Sat, Mar 20, 2010 at 2:55 PM, Sedat Dilek <sed...@go...> wrote:
> My autogen.sh line looks like this:
>
> $ ./autogen.sh --prefix=/usr --with-driver=dri
> --with-dri-driverdir=/usr/lib/dri --with-dri-drivers=r300,swrast
> --enable-gallium-radeon --with-state-trackers=dri,glx --enable-glx-tls
> --enable-debug
>
> - Sedat -
>
> On Sat, Mar 20, 2010 at 2:51 PM, Sedat Dilek <sed...@go...> wrote:
>> Hi,
>>
>> while upgrading my mesa from 7.8 GIT branch, I saw with
>>
>> commit 41a87a43e11c664935349f938022d58d3e22da4e
>> "glapi: Correctly generate static disatches for X86."
>>
>> the build breaking (especially with xdemos).
>>
>> - Sedat -
>>
>> [build.log]
>> ....
>> ccache gcc -I../../include  -g -O2 -Wall -Wmissing-prototypes -std=c99
>> -ffast-math -fvisibility=hidden -fno-strict-aliasing -g  -fPIC
>> -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM
>> -D_GNU_SOURCE -DPTHREADS -DDEBUG -DHAVE_POSIX_MEMALIGN -DGLX_USE_TLS
>> -DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER
>> -DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -DHAVE_ALIAS
>> glxdemo.c -L../../lib -lGL -L/usr/lib  -lm -lX11 -lpthread -o glxdemo
>> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
>> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
>> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
>> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
>> collect2: ld returned 1 exit status
>> make[2]: *** [glsync] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
>>
>> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
>> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
>> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
>> collect2: ld returned 1 exit status
>> make[2]: *** [glxdemo] Error 1
>> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
>> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
>> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
>> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
>> collect2: ld returned 1 exit status
>> make[2]: *** [glthreads] Error 1
>> make[2]: Leaving directory `/home/sd/src/mesa/mesa/progs/xdemos'
>> make[1]: *** [subdirs] Error 1
>> make[1]: Leaving directory `/home/sd/src/mesa/mesa/progs'
>> make: *** [default] Error 1
>>
>

Re: [Mesa3d-dev] mesa 7.8 GIT: Broken by "glapi: Correctly generate static disatches for X86."

[Chia-I Wu <ol...@lu...>]

On Sat, Mar 20, 2010 at 9:51 PM, Sedat Dilek <sed...@go...> wrote:
> while upgrading my mesa from 7.8 GIT branch, I saw with
> commit 41a87a43e11c664935349f938022d58d3e22da4e
> "glapi: Correctly generate static disatches for X86."
> the build breaking (especially with xdemos).
Sorry for introducing the build error.  I've committed a fix to it.  Can you
git pull again and see if it works for you too?

-- 
ol...@Lu...

Re: [Mesa3d-dev] mesa 7.8 GIT: Broken by "glapi: Correctly generate static disatches for X86."

[Sedat D. <sed...@go...>]

commit	6fed3a9fa0a87ae797f995de5b51eb9be3493fe0
"glapi: Fix aliases to non-static functions."

...fixes here the issues.

THX for the quick fix.

- Sedat -

On Sat, Mar 20, 2010 at 5:11 PM, Chia-I Wu <ol...@lu...> wrote:
> On Sat, Mar 20, 2010 at 9:51 PM, Sedat Dilek <sed...@go...> wrote:
>> while upgrading my mesa from 7.8 GIT branch, I saw with
>> commit 41a87a43e11c664935349f938022d58d3e22da4e
>> "glapi: Correctly generate static disatches for X86."
>> the build breaking (especially with xdemos).
> Sorry for introducing the build error.  I've committed a fix to it.  Can you
> git pull again and see if it works for you too?
>
> --
> ol...@Lu...
>

Re: [Mesa3d-dev] mesa 7.8 GIT: Broken by "glapi: Correctly generate static disatches for X86."

[Sedat D. <sed...@go...>]

[Only for documenting the build-error]

$ cd ~/src/mesa/mesa/progs/xdemos/

$ undefref="glBlitFramebufferEXT glDeleteVertexArraysAPPLE
glIsVertexArrayAPPLE glBlendEquationSeparateEXT"

GOOD:
$ for i in $undefref ; do objdump -x ../../lib/libGL.so | grep $i ; done
0001b000 l     F .text	000000a0              __indirect_glBlitFramebufferEXT
0001b570 l     F .text	00000058
__indirect_glBlendEquationSeparateEXT

BAD:
$ for i in $undefref ; do objdump -x ../../lib/libGL.so | grep $i ; done
0001b000 l     F .text  000000a0              __indirect_glBlitFramebufferEXT
00000000         *UND*  00000000              glBlitFramebufferEXT
00000000         *UND*  00000000              glDeleteVertexArraysAPPLE
00000000         *UND*  00000000              glIsVertexArrayAPPLE
0001b570 l     F .text  00000058
__indirect_glBlendEquationSeparateEXT
00000000         *UND*  00000000              glBlendEquationSeparateEXT

- Sedat -

On Sat, Mar 20, 2010 at 5:11 PM, Chia-I Wu <ol...@lu...> wrote:
> On Sat, Mar 20, 2010 at 9:51 PM, Sedat Dilek <sed...@go...> wrote:
>> while upgrading my mesa from 7.8 GIT branch, I saw with
>> commit 41a87a43e11c664935349f938022d58d3e22da4e
>> "glapi: Correctly generate static disatches for X86."
>> the build breaking (especially with xdemos).
> Sorry for introducing the build error.  I've committed a fix to it.  Can you
> git pull again and see if it works for you too?
>
> --
> ol...@Lu...
>

Re: [Mesa3d-dev] mesa 7.8 GIT: Broken by "glapi: Correctly generate static disatches for X86."

[Michel D. <mi...@da...>]

On Sat, 2010-03-20 at 14:51 +0100, Sedat Dilek wrote: 
> Hi,
> 
> while upgrading my mesa from 7.8 GIT branch, I saw with
> 
> commit 41a87a43e11c664935349f938022d58d3e22da4e
> "glapi: Correctly generate static disatches for X86."
> 
> the build breaking (especially with xdemos).
> 
> - Sedat -
> 
> [build.log]
> ....
> ccache gcc -I../../include  -g -O2 -Wall -Wmissing-prototypes -std=c99
> -ffast-math -fvisibility=hidden -fno-strict-aliasing -g  -fPIC
> -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM
> -D_GNU_SOURCE -DPTHREADS -DDEBUG -DHAVE_POSIX_MEMALIGN -DGLX_USE_TLS
> -DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER
> -DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -DHAVE_ALIAS
> glxdemo.c -L../../lib -lGL -L/usr/lib  -lm -lX11 -lpthread -o glxdemo
> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
> collect2: ld returned 1 exit status
> make[2]: *** [glsync] Error 1
> make[2]: *** Waiting for unfinished jobs....
> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
> 
> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
> collect2: ld returned 1 exit status
> make[2]: *** [glxdemo] Error 1
> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
> collect2: ld returned 1 exit status
> make[2]: *** [glthreads] Error 1

These demos are broken: Those GL API calls aren't part of the Linux
OpenGL ABI, so their addresses need to be retrieved with
glXGetProcAddress().


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer

Re: [Mesa3d-dev] mesa 7.8 GIT: Broken by "glapi: Correctly generate static disatches for X86."

[Chia-I Wu <ol...@lu...>]

2010/3/22 Michel Dänzer <mi...@da...>:
> On Sat, 2010-03-20 at 14:51 +0100, Sedat Dilek wrote:
>> while upgrading my mesa from 7.8 GIT branch, I saw with
>>
>> commit 41a87a43e11c664935349f938022d58d3e22da4e
>> "glapi: Correctly generate static disatches for X86."
>>
>> the build breaking (especially with xdemos).
>>
>> - Sedat -
>>
>> [build.log]
>> ....
>> ccache gcc -I../../include  -g -O2 -Wall -Wmissing-prototypes -std=c99
>> -ffast-math -fvisibility=hidden -fno-strict-aliasing -g  -fPIC
>> -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM
>> -D_GNU_SOURCE -DPTHREADS -DDEBUG -DHAVE_POSIX_MEMALIGN -DGLX_USE_TLS
>> -DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER
>> -DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -DHAVE_ALIAS
>> glxdemo.c -L../../lib -lGL -L/usr/lib  -lm -lX11 -lpthread -o glxdemo
>> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
>> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
>> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
>> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
>> collect2: ld returned 1 exit status
>> make[2]: *** [glsync] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
>>
>> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
>> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
>> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
>> collect2: ld returned 1 exit status
>> make[2]: *** [glxdemo] Error 1
>> ../../lib/libGL.so: undefined reference to `glBlitFramebufferEXT'
>> ../../lib/libGL.so: undefined reference to `glDeleteVertexArraysAPPLE'
>> ../../lib/libGL.so: undefined reference to `glIsVertexArrayAPPLE'
>> ../../lib/libGL.so: undefined reference to `glBlendEquationSeparateEXT'
>> collect2: ld returned 1 exit status
>> make[2]: *** [glthreads] Error 1
>
> These demos are broken: Those GL API calls aren't part of the Linux
> OpenGL ABI, so their addresses need to be retrieved with
> glXGetProcAddress().
The errors were due to missing symbols in libGL.so.  The demos did not call
them.  The bug was triggered by me in 41a87a43e11c664935349f938022d58d3e22da4e
and was fixed in 6fed3a9fa0a87ae797f995de5b51eb9be3493fe0.

-- 
ol...@Lu...