mesa3d-dev

Re: [Mesa3d-dev] [PATCH] mesa/st: Gallium quads, by spec, never change provoking vertex.

[Brian P. <br...@vm...>]

Corbin Simpson wrote:
>>From 215714d54a7f38b9add236bcc1c795e8b5d92867 Mon Sep 17 00:00:00 2001
> From: Corbin Simpson <Mos...@gm...>
> Date: Wed, 10 Feb 2010 10:39:18 -0800
> Subject: [PATCH] mesa/st: Gallium quads, by spec, never change provoking vertex.
> 
> Fixes glean/clipFlat. Softpipe might be broken; I haven't figured out
> how to test it in this new API world. :T
> ---
>  src/mesa/state_tracker/st_extensions.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_extensions.c
> b/src/mesa/state_tracker/st_extensions.c
> index d5f5854..e2d871b 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -137,6 +137,9 @@ void st_init_limits(struct st_context *st)
>     /* XXX separate query for early function return? */
>     st->ctx->Shader.EmitContReturn =
>        screen->get_param(screen, PIPE_CAP_TGSI_CONT_SUPPORTED);
> +
> +   /* Quads always follow GL provoking rules. */
> +   c->QuadsFollowProvokingVertexConvention = GL_FALSE;
>  }

This causes the glean clipFlat test to fail with softpipe.  The 
gallium softpipe driver _does_ implement the "quad follows provoking 
vertex" convention.

I don't have time right now to update the softpipe driver so this 
patch will have to wait a while.  Maybe someone else can look at it 
sooner.

-Brian

Re: [Mesa3d-dev] [PATCH] mesa/st: Gallium quads, by spec, never change provoking vertex.

[Marek O. <ma...@gm...>]

The attached patches change softpipe and llvmpipe so that they never provoke
the first vertex for quads. Please review. I think that these and the
Corbin's one could be pushed by now, couldn't they?

-Marek

On Thu, Feb 11, 2010 at 4:03 PM, Brian Paul <br...@vm...> wrote:

> Corbin Simpson wrote:
> >>From 215714d54a7f38b9add236bcc1c795e8b5d92867 Mon Sep 17 00:00:00 2001
> > From: Corbin Simpson <Mos...@gm...>
> > Date: Wed, 10 Feb 2010 10:39:18 -0800
> > Subject: [PATCH] mesa/st: Gallium quads, by spec, never change provoking
> vertex.
> >
> > Fixes glean/clipFlat. Softpipe might be broken; I haven't figured out
> > how to test it in this new API world. :T
> > ---
> >  src/mesa/state_tracker/st_extensions.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/src/mesa/state_tracker/st_extensions.c
> > b/src/mesa/state_tracker/st_extensions.c
> > index d5f5854..e2d871b 100644
> > --- a/src/mesa/state_tracker/st_extensions.c
> > +++ b/src/mesa/state_tracker/st_extensions.c
> > @@ -137,6 +137,9 @@ void st_init_limits(struct st_context *st)
> >     /* XXX separate query for early function return? */
> >     st->ctx->Shader.EmitContReturn =
> >        screen->get_param(screen, PIPE_CAP_TGSI_CONT_SUPPORTED);
> > +
> > +   /* Quads always follow GL provoking rules. */
> > +   c->QuadsFollowProvokingVertexConvention = GL_FALSE;
> >  }
>
> This causes the glean clipFlat test to fail with softpipe.  The
> gallium softpipe driver _does_ implement the "quad follows provoking
> vertex" convention.
>
> I don't have time right now to update the softpipe driver so this
> patch will have to wait a while.  Maybe someone else can look at it
> sooner.
>
> -Brian
>
>
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> Mesa3d-dev mailing list
> Mes...@li...
> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
>

Re: [Mesa3d-dev] [PATCH] mesa/st: Gallium quads, by spec, never change provoking vertex.

[Brian P. <br...@vm...>]

Looks OK, but have you tested with Glean's clipFlat test?  If it 
passes go ahead and commit.

-Brian

Marek Olšák wrote:
> The attached patches change softpipe and llvmpipe so that they never 
> provoke the first vertex for quads. Please review. I think that these 
> and the Corbin's one could be pushed by now, couldn't they?
> 
> -Marek
> 
> On Thu, Feb 11, 2010 at 4:03 PM, Brian Paul <br...@vm... 
> <mailto:br...@vm...>> wrote:
> 
>     Corbin Simpson wrote:
>      >>From 215714d54a7f38b9add236bcc1c795e8b5d92867 Mon Sep 17 00:00:00
>     2001
>      > From: Corbin Simpson <Mos...@gm...
>     <mailto:Mos...@gm...>>
>      > Date: Wed, 10 Feb 2010 10:39:18 -0800
>      > Subject: [PATCH] mesa/st: Gallium quads, by spec, never change
>     provoking vertex.
>      >
>      > Fixes glean/clipFlat. Softpipe might be broken; I haven't figured out
>      > how to test it in this new API world. :T
>      > ---
>      >  src/mesa/state_tracker/st_extensions.c |    3 +++
>      >  1 files changed, 3 insertions(+), 0 deletions(-)
>      >
>      > diff --git a/src/mesa/state_tracker/st_extensions.c
>      > b/src/mesa/state_tracker/st_extensions.c
>      > index d5f5854..e2d871b 100644
>      > --- a/src/mesa/state_tracker/st_extensions.c
>      > +++ b/src/mesa/state_tracker/st_extensions.c
>      > @@ -137,6 +137,9 @@ void st_init_limits(struct st_context *st)
>      >     /* XXX separate query for early function return? */
>      >     st->ctx->Shader.EmitContReturn =
>      >        screen->get_param(screen, PIPE_CAP_TGSI_CONT_SUPPORTED);
>      > +
>      > +   /* Quads always follow GL provoking rules. */
>      > +   c->QuadsFollowProvokingVertexConvention = GL_FALSE;
>      >  }
> 
>     This causes the glean clipFlat test to fail with softpipe.  The
>     gallium softpipe driver _does_ implement the "quad follows provoking
>     vertex" convention.
> 
>     I don't have time right now to update the softpipe driver so this
>     patch will have to wait a while.  Maybe someone else can look at it
>     sooner.
> 
>     -Brian
> 
>     ------------------------------------------------------------------------------
>     SOLARIS 10 is the OS for Data Centers - provides features such as
>     DTrace,
>     Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
>     http://p.sf.net/sfu/solaris-dev2dev
>     _______________________________________________
>     Mesa3d-dev mailing list
>     Mes...@li...
>     <mailto:Mes...@li...>
>     https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
> 
>