From: michal <mi...@vm...> - 2010-03-01 16:09:07
|
Hi, This branch removes bypass_vs_clip_and_viewport flag from pipe rasterizer state. The benefits of having this bit around were dubious for everybody and burdensome for driver writers. All the utility code that relied on this flag have been rewritten to pass vertex positions in clip space and set clip and viewport state. I would like to ask the maintainers of u_blitter module to please test my changes and provide feedback. Please review. Thanks. |
From: Marek O. <ma...@gm...> - 2010-03-02 01:08:27
|
Hi Michal, This branch breaks 2 piglit tests with r300g: depthrange-clear texdepth However I haven't investigated these and won't get to them until the weekend. I personally don't mind fixing the regressions after the merge (but I'm not the maintainer of r300g). Anyway I'm glad to see bypass_vs_clip_and_viewport dying. -Marek On Mon, Mar 1, 2010 at 5:08 PM, michal <mi...@vm...> wrote: > Hi, > > This branch removes bypass_vs_clip_and_viewport flag from pipe > rasterizer state. The benefits of having this bit around were dubious > for everybody and burdensome for driver writers. > > All the utility code that relied on this flag have been rewritten to > pass vertex positions in clip space and set clip and viewport state. I > would like to ask the maintainers of u_blitter module to please test my > changes and provide feedback. > > Please review. > > Thanks. > > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Mesa3d-dev mailing list > Mes...@li... > https://lists.sourceforge.net/lists/listinfo/mesa3d-dev > |
From: Marek O. <ma...@gm...> - 2010-03-02 02:48:56
|
Ahhh, I am a bad liar. The attached patch fixes the regressions. -Marek On Tue, Mar 2, 2010 at 2:08 AM, Marek Olšák <ma...@gm...> wrote: > Hi Michal, > > This branch breaks 2 piglit tests with r300g: > > depthrange-clear > texdepth > > However I haven't investigated these and won't get to them until the > weekend. I personally don't mind fixing the regressions after the merge (but > I'm not the maintainer of r300g). Anyway I'm glad to see > bypass_vs_clip_and_viewport dying. > > -Marek > > > On Mon, Mar 1, 2010 at 5:08 PM, michal <mi...@vm...> wrote: > >> Hi, >> >> This branch removes bypass_vs_clip_and_viewport flag from pipe >> rasterizer state. The benefits of having this bit around were dubious >> for everybody and burdensome for driver writers. >> >> All the utility code that relied on this flag have been rewritten to >> pass vertex positions in clip space and set clip and viewport state. I >> would like to ask the maintainers of u_blitter module to please test my >> changes and provide feedback. >> >> Please review. >> >> Thanks. >> >> >> >> ------------------------------------------------------------------------------ >> Download Intel® Parallel Studio Eval >> Try the new software tools for yourself. Speed compiling, find bugs >> proactively, and fine-tune applications for parallel performance. >> See why Intel Parallel Studio got high marks during beta. >> http://p.sf.net/sfu/intel-sw-dev >> _______________________________________________ >> Mesa3d-dev mailing list >> Mes...@li... >> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev >> > > |
From: Keith W. <ke...@vm...> - 2010-03-02 10:44:39
|
Michal, This is looking good to me - feel free to merge once any loose ends are tied up. Keith On Mon, 2010-03-01 at 17:46 -0800, Marek Olšák wrote: > Ahhh, I am a bad liar. The attached patch fixes the regressions. > > -Marek > > On Tue, Mar 2, 2010 at 2:08 AM, Marek Olšák <ma...@gm...> wrote: > Hi Michal, > > This branch breaks 2 piglit tests with r300g: > > depthrange-clear > texdepth > > However I haven't investigated these and won't get to them > until the weekend. I personally don't mind fixing the > regressions after the merge (but I'm not the maintainer of > r300g). Anyway I'm glad to see bypass_vs_clip_and_viewport > dying. > > -Marek > > > > On Mon, Mar 1, 2010 at 5:08 PM, michal <mi...@vm...> > wrote: > Hi, > > This branch removes bypass_vs_clip_and_viewport flag > from pipe > rasterizer state. The benefits of having this bit > around were dubious > for everybody and burdensome for driver writers. > > All the utility code that relied on this flag have > been rewritten to > pass vertex positions in clip space and set clip and > viewport state. I > would like to ask the maintainers of u_blitter module > to please test my > changes and provide feedback. > > Please review. > > Thanks. > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed > compiling, find bugs > proactively, and fine-tune applications for parallel > performance. > See why Intel Parallel Studio got high marks during > beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Mesa3d-dev mailing list > Mes...@li... > https://lists.sourceforge.net/lists/listinfo/mesa3d-dev > > > |