mesa3d-dev

[Mesa3d-dev] sources.lst files

[Sven M. H. <pe...@gm...>]

Again,

I thought I'd drop a note about this, so nobody trips over it.

As there is a lot of flux in the list of source files especially in src/
it's hard to keep track of every file removed/renamed/moved/whatever. I've
assembled a script gen_srclists.sh in the top source dir that generates a file
source.lst in every directory which has a Makefile.am with exactly one SOURCES
directive and an "include sources.lst" line. It fills sources.lst with simply
a sorted list of all .c and .h file in the respective directory.

The script is just meant as a hack to quickly create _some_ list of files. If
that list is not 100% right it can easily be corrected. Further, renaming the
list file will of course lock the script out.


Regards,
Sven

PS: Maybe we could even modify the "manual" Makefiles to use these list files.
    That way the need for seperate maintainance of the traditional and the
    automake lists would disappear. Comments anyone?

-- 
"Would the All-Seeing Eye please look in my direction?"
 [ KeyID........: 0xC297FEAB ]
 [ Fingerprint..: FEA5 0F93 7320 3F39 66A5  AED3 073F 2D5F C297 FEAB ]

Re: [Mesa3d-dev] sources.lst files

[Brian P. <br...@va...>]

"Sven M. Hallberg" wrote:
> 
> Again,
> 
> I thought I'd drop a note about this, so nobody trips over it.
> 
> As there is a lot of flux in the list of source files especially in src/
> it's hard to keep track of every file removed/renamed/moved/whatever. I've
> assembled a script gen_srclists.sh in the top source dir that generates a file
> source.lst in every directory which has a Makefile.am with exactly one SOURCES
> directive and an "include sources.lst" line. It fills sources.lst with simply
> a sorted list of all .c and .h file in the respective directory.
> 
> The script is just meant as a hack to quickly create _some_ list of files. If
> that list is not 100% right it can easily be corrected. Further, renaming the
> list file will of course lock the script out.
> 
> Regards,
> Sven
> 
> PS: Maybe we could even modify the "manual" Makefiles to use these list files.
>     That way the need for seperate maintainance of the traditional and the
>     automake lists would disappear. Comments anyone?


The src/Makefile.X11 file is always up to date.  It's what Keith
and I use.  If your scripts will help you that's fine.

-Brian

Re: [Mesa3d-dev] sources.lst files

[Sven M. H. <pe...@gm...>]

On Mon, Feb 12, 2001 at 12:15:44PM -0700, Brian Paul wrote:
> > PS: Maybe we could even modify the "manual" Makefiles to use these list files.
> >     That way the need for seperate maintainance of the traditional and the
> >     automake lists would disappear. Comments anyone?
> 
> 
> The src/Makefile.X11 file is always up to date.  It's what Keith
> and I use.  If your scripts will help you that's fine.

However, pulling the source file lists out would directly eliminate?
the need for that double maintanence work. That's what I meant.

Do you think we could do that? I would of course do the modification work,
on a seperate branch. You and Keith would just have to agree to use couple of
seperate file for specifying the source lists. Or do you see a problem there?


-Sven

-- 
"Would the All-Seeing Eye please look in my direction?"
 [ KeyID........: 0xC297FEAB ]
 [ Fingerprint..: FEA5 0F93 7320 3F39 66A5  AED3 073F 2D5F C297 FEAB ]

Re: [Mesa3d-dev] sources.lst files

[Brian P. <br...@va...>]

"Sven M. Hallberg" wrote:
> 
> On Mon, Feb 12, 2001 at 12:15:44PM -0700, Brian Paul wrote:
> > > PS: Maybe we could even modify the "manual" Makefiles to use these list files.
> > >     That way the need for seperate maintainance of the traditional and the
> > >     automake lists would disappear. Comments anyone?
> >
> >
> > The src/Makefile.X11 file is always up to date.  It's what Keith
> > and I use.  If your scripts will help you that's fine.
> 
> However, pulling the source file lists out would directly eliminate?
> the need for that double maintanence work. That's what I meant.
> 
> Do you think we could do that? I would of course do the modification work,
> on a seperate branch. You and Keith would just have to agree to use couple of
> seperate file for specifying the source lists. Or do you see a problem there?

I think the sources for Mesa 3.5 are quickly settling down and I don't
think there will be any big changes anymore (Keith?).  If that's the
case, do you still want to make a seperate sources file?

I guess I really don't care either way.

-Brian

Re: [Mesa3d-dev] sources.lst files

[Keith W. <ke...@va...>]

Brian Paul wrote:
> 
> "Sven M. Hallberg" wrote:
> >
> > On Mon, Feb 12, 2001 at 12:15:44PM -0700, Brian Paul wrote:
> > > > PS: Maybe we could even modify the "manual" Makefiles to use these list files.
> > > >     That way the need for seperate maintainance of the traditional and the
> > > >     automake lists would disappear. Comments anyone?
> > >
> > >
> > > The src/Makefile.X11 file is always up to date.  It's what Keith
> > > and I use.  If your scripts will help you that's fine.
> >
> > However, pulling the source file lists out would directly eliminate?
> > the need for that double maintanence work. That's what I meant.
> >
> > Do you think we could do that? I would of course do the modification work,
> > on a seperate branch. You and Keith would just have to agree to use couple of
> > seperate file for specifying the source lists. Or do you see a problem there?
> 
> I think the sources for Mesa 3.5 are quickly settling down and I don't
> think there will be any big changes anymore (Keith?).  If that's the
> case, do you still want to make a seperate sources file?

I removed a file 't_vb_materials.c' yesterday.

I plan on adding a bunch of templates to make driver writing easier (you've
already seen a few in the tnl/ directory; they really belong in a directory of
their own, I think).

Otherwise, I think that's it for me.

Keith

Re: [Mesa3d-dev] sources.lst files

[Brian P. <br...@va...>]

Keith Whitwell wrote:
> 
> Brian Paul wrote:
> > I think the sources for Mesa 3.5 are quickly settling down and I don't
> > think there will be any big changes anymore (Keith?).  If that's the
> > case, do you still want to make a seperate sources file?
> 
> I removed a file 't_vb_materials.c' yesterday.

t_vb_materials.c or t_vb_material.c?

_tnl_update_material_stage is referenced in FX/fxdd.c and is in
t_vb_material.c.  I added it to the makefile and added an extern
declaration for _tnl_update_material_stage to t_pipeline.h to make
everything compile.

All the conformance tests pass now.

-Brian

Re: [Mesa3d-dev] sources.lst files

[Gareth H. <ga...@va...>]

Brian Paul wrote:
> 
> All the conformance tests pass now.

I don't think I'll ever get sick of hearing that...

-- Gareth

Re: [Mesa3d-dev] sources.lst files

[<de...@ko...>]

Gareth Hughes writes:
>Brian Paul wrote:
>> 
>> All the conformance tests pass now.
>
>I don't think I'll ever get sick of hearing that...
>
>-- Gareth
>
>_______________________________________________
>Mesa3d-dev mailing list
>Mes...@li...
>http://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Don't think that passing the conformance tests  is proof you're doing
everything correctly.  We've got scads of visual display problems with Mesa in
our application, that other drivers handle just fine.  Then again, we've
got visual display problems that crop up under the other drivers too.
We haven't yet found a completely acceptable openGL implementation.

----------------------------------------------------------------------------
Email: de...@cg...   David Konerding   WWW: http://picasso.ucsf.edu/~dek
-----------------------------------------------------------------------------

OpenGL conformance (was Re: [Mesa3d-dev] sources.lst files)

[Gareth H. <ga...@va...>]

de...@ko... wrote:
> 
> Don't think that passing the conformance tests  is proof you're doing
> everything correctly.  We've got scads of visual display problems with Mesa in
> our application, that other drivers handle just fine.  Then again, we've
> got visual display problems that crop up under the other drivers too.
> We haven't yet found a completely acceptable openGL implementation.

I am aware of this.  However, passing the OpenGL conformance tests is a
large step in the right direction, wouldn't you agree?  It is critical
if Mesa is to ever become an officially-recognized OpenGL
implementation, rather than "an OpenGL work-alike" library or whatever
it has to be called these days.

-- Gareth

Re: [Mesa3d-dev] sources.lst files

[Brian P. <br...@va...>]

de...@ko... wrote:
> 
> Gareth Hughes writes:
> >Brian Paul wrote:
> >>
> >> All the conformance tests pass now.
> >
> >I don't think I'll ever get sick of hearing that...
> >
> >-- Gareth
> >
> >_______________________________________________
> >Mesa3d-dev mailing list
> >Mes...@li...
> >http://lists.sourceforge.net/lists/listinfo/mesa3d-dev
> 
> Don't think that passing the conformance tests  is proof you're doing
> everything correctly.

We don't.


> We've got scads of visual display problems with Mesa in
> our application, that other drivers handle just fine.  Then again, we've
> got visual display problems that crop up under the other drivers too.
> We haven't yet found a completely acceptable openGL implementation.

Have you reported these problems?  I'm unlikely to fix bugs that
I'm not aware of.

-Brian

Re: [Mesa3d-dev] sources.lst files

[Allen A. <ak...@po...>]

On Sun, Feb 18, 2001 at 10:45:19PM -0800, de...@ko... wrote:
| 
| Don't think that passing the conformance tests  is proof you're doing
| everything correctly.  We've got scads of visual display problems with Mesa in
| our application...

Nothing helps stamp out bugs (and prevent their return) better than
adding to the test suites that the driver developers use.  If the
problems you're seeing can be condensed down to simple test cases, we
can add them to the glean suite to make sure they're checked in the
future.  (Or you're welcome to add them yourself if you want to
register as a glean developer -- start at http://glean.sourceforge.net/)

Allen

Re: [Mesa3d-dev] sources.lst files

[Keith W. <ke...@va...>]

Brian Paul wrote:
> 
> Keith Whitwell wrote:
> >
> > Brian Paul wrote:
> > > I think the sources for Mesa 3.5 are quickly settling down and I don't
> > > think there will be any big changes anymore (Keith?).  If that's the
> > > case, do you still want to make a seperate sources file?
> >
> > I removed a file 't_vb_materials.c' yesterday.
> 
> t_vb_materials.c or t_vb_material.c?
> 
> _tnl_update_material_stage is referenced in FX/fxdd.c and is in
> t_vb_material.c.  I added it to the makefile and added an extern
> declaration for _tnl_update_material_stage to t_pipeline.h to make
> everything compile.

I'll take it out again... Sorry.

Keith

Re: [Mesa3d-dev] sources.lst files

[Keith W. <ke...@va...>]

Brian Paul wrote:
> 
> Keith Whitwell wrote:
> >
> > Brian Paul wrote:
> > > I think the sources for Mesa 3.5 are quickly settling down and I don't
> > > think there will be any big changes anymore (Keith?).  If that's the
> > > case, do you still want to make a seperate sources file?
> >
> > I removed a file 't_vb_materials.c' yesterday.
> 
> t_vb_materials.c or t_vb_material.c?
> 
> _tnl_update_material_stage is referenced in FX/fxdd.c and is in
> t_vb_material.c.  I added it to the makefile and added an extern
> declaration for _tnl_update_material_stage to t_pipeline.h to make
> everything compile.
> 
> All the conformance tests pass now.

I'm still seeing an error in one of the seperate specular tests in
mustpass.c;  Previously this was segfaulting (due to the
seperate-specular/texture stuff I've been fixing), which seems to be different
to the results you were getting (you sent me a list of failures that I
couldn't reach because of the segfault).

Can you recheck and see if you also get the specular failure?  I'm running at
16bpp on my laptop.

Keith

Re: [Mesa3d-dev] sources.lst files

[Brian P. <br...@va...>]

Keith Whitwell wrote:
> 
> I'm still seeing an error in one of the seperate specular tests in
> mustpass.c;  Previously this was segfaulting (due to the
> seperate-specular/texture stuff I've been fixing), which seems to be different
> to the results you were getting (you sent me a list of failures that I
> couldn't reach because of the segfault).
> 
> Can you recheck and see if you also get the specular failure?  I'm running at
> 16bpp on my laptop.

Yup, I'm getting the failure now too.  I'll start looking into it.

-Brian

Re: [Mesa3d-dev] sources.lst files

[Keith W. <ke...@va...>]

Brian Paul wrote:
> 
> Keith Whitwell wrote:
> >
> > I'm still seeing an error in one of the seperate specular tests in
> > mustpass.c;  Previously this was segfaulting (due to the
> > seperate-specular/texture stuff I've been fixing), which seems to be different
> > to the results you were getting (you sent me a list of failures that I
> > couldn't reach because of the segfault).
> >
> > Can you recheck and see if you also get the specular failure?  I'm running at
> > 16bpp on my laptop.
> 
> Yup, I'm getting the failure now too.  I'll start looking into it.

I'll look into it too; it's probably something I've done.

Keith

Re: [Mesa3d-dev] sources.lst files

[Sven M. H. <pe...@gm...>]

On Fri, Feb 16, 2001 at 10:36:17AM -0700, Keith Whitwell wrote:
> > > However, pulling the source file lists out would directly eliminate?
> > > the need for that double maintanence work. That's what I meant.
> > >
> > > Do you think we could do that? I would of course do the modification work,
> > > on a seperate branch. You and Keith would just have to agree to use couple of
> > > seperate file for specifying the source lists. Or do you see a problem there?
> > 
> > I think the sources for Mesa 3.5 are quickly settling down and I don't
> > think there will be any big changes anymore (Keith?).  If that's the
> > case, do you still want to make a seperate sources file?
> 
> I removed a file 't_vb_materials.c' yesterday.
> 
> I plan on adding a bunch of templates to make driver writing easier (you've
> already seen a few in the tnl/ directory; they really belong in a directory of
> their own, I think).
> 
> Otherwise, I think that's it for me.

I can't judge how much flux there will be in the source file lists, however if
that's all for the not-too-distant future I guess it'll be unnecessary. Also
just using *.[ch] seems to work pretty well, since the directory organization
is clean (i.e. if there's only one source list var in the Makefile.am, *.[ch]
is safe to assume).

So, for now we'll stick with the seperate maintanence of Makefile.X11 and
Makefile.am.


-Sven

-- 
"Would the All-Seeing Eye please look in my direction?"
 [ KeyID........: 0xC297FEAB ]
 [ Fingerprint..: FEA5 0F93 7320 3F39 66A5  AED3 073F 2D5F C297 FEAB ]