mesa3d-dev

[Mesa3d-dev] Piglit fbo tests

[Maciej C. <m.c...@gm...>]

Hi,

following 3 piglit tests are failing on r300 because they're trying to use 
GL_ARB_texture_non_power_of_two without checking if this extension is 
available:

fbo-blit
fbo-nodepth-test
fbo-nostencil-test

I'm not sure what solution is preferable, 1) change the teximage sizes to be 
POT, 2) require ARB_texture_npot.
I've tried first solution for fbo-blit but it segfaults, trying to execute 
function at null address, so it would require some more investigation.

Regards,
Maciej

Re: [Mesa3d-dev] Piglit fbo tests

[Brian P. <br...@vm...>]

Maciej Cencora wrote:
> Hi,
> 
> following 3 piglit tests are failing on r300 because they're trying to use 
> GL_ARB_texture_non_power_of_two without checking if this extension is 
> available:
> 
> fbo-blit
> fbo-nodepth-test
> fbo-nostencil-test
> 
> I'm not sure what solution is preferable, 1) change the teximage sizes to be 
> POT, 2) require ARB_texture_npot.
> I've tried first solution for fbo-blit but it segfaults, trying to execute 
> function at null address, so it would require some more investigation.

We should use POT texture sizes so that the test always does _something_.

Where's the crash?

-Brian

Re: [Mesa3d-dev] Piglit fbo tests

[Brian P. <br...@vm...>]

Brian Paul wrote:
> Maciej Cencora wrote:
>> Hi,
>>
>> following 3 piglit tests are failing on r300 because they're trying to use 
>> GL_ARB_texture_non_power_of_two without checking if this extension is 
>> available:
>>
>> fbo-blit
>> fbo-nodepth-test
>> fbo-nostencil-test
>>
>> I'm not sure what solution is preferable, 1) change the teximage sizes to be 
>> POT, 2) require ARB_texture_npot.
>> I've tried first solution for fbo-blit but it segfaults, trying to execute 
>> function at null address, so it would require some more investigation.
> 
> We should use POT texture sizes so that the test always does _something_.

I've fixed the fbo-blit test to use a POT texture.  Maybe you can fix 
the other tests similarly.

BTW, I'm adding additional sub-tests to fbo-blit.c to investigate some 
other bugs I've recently found...

-Brian

Re: [Mesa3d-dev] Piglit fbo tests

[Maciej C. <m.c...@gm...>]

Dnia środa, 10 marca 2010 o 16:36:01 Brian Paul napisał(a):
> Brian Paul wrote:
> > Maciej Cencora wrote:
> >> Hi,
> >>
> >> following 3 piglit tests are failing on r300 because they're trying to
> >> use GL_ARB_texture_non_power_of_two without checking if this extension
> >> is available:
> >>
> >> fbo-blit
> >> fbo-nodepth-test
> >> fbo-nostencil-test
> >>
> >> I'm not sure what solution is preferable, 1) change the teximage sizes
> >> to be POT, 2) require ARB_texture_npot.
> >> I've tried first solution for fbo-blit but it segfaults, trying to
> >> execute function at null address, so it would require some more
> >> investigation.
> >
> > We should use POT texture sizes so that the test always does _something_.
> 
> I've fixed the fbo-blit test to use a POT texture.  Maybe you can fix
> the other tests similarly.
> 
> BTW, I'm adding additional sub-tests to fbo-blit.c to investigate some
> other bugs I've recently found...
> 
> -Brian
> 

Sure, I'll look into it.

Regards,
Maciej

Re: [Mesa3d-dev] Piglit fbo tests

[Maciej C. <m.c...@gm...>]

Dnia środa, 10 marca 2010 o 19:17:25 Maciej Cencora napisał(a):
> Dnia środa, 10 marca 2010 o 16:36:01 Brian Paul napisał(a):
> > Brian Paul wrote:
> > > Maciej Cencora wrote:
> > >> Hi,
> > >>
> > >> following 3 piglit tests are failing on r300 because they're trying to
> > >> use GL_ARB_texture_non_power_of_two without checking if this extension
> > >> is available:
> > >>
> > >> fbo-blit
> > >> fbo-nodepth-test
> > >> fbo-nostencil-test
> > >>
> > >> I'm not sure what solution is preferable, 1) change the teximage sizes
> > >> to be POT, 2) require ARB_texture_npot.
> > >> I've tried first solution for fbo-blit but it segfaults, trying to
> > >> execute function at null address, so it would require some more
> > >> investigation.
> > >
> > > We should use POT texture sizes so that the test always does
> > > _something_.
> >
> > I've fixed the fbo-blit test to use a POT texture.  Maybe you can fix
> > the other tests similarly.
> >
> > BTW, I'm adding additional sub-tests to fbo-blit.c to investigate some
> > other bugs I've recently found...
> >
> > -Brian
> 
> Sure, I'll look into it.
> 
> Regards,
> Maciej
> 

It looks like you've forgotten to remove  the ARB_npot check for fbo-blit. 
After removing it the tests segfaults.
#0  0x0000000000000000 in ?? ()
#1  0x000000000042cfac in run_test ()
#2  0x000000000042d1f3 in piglit_display ()
#3  0x000000000042e639 in display ()
#4  0x00007ffff7682ddf in processWindowWorkList (window=0x673a90) at 
glut_event.c:1306
#5  0x00007ffff7682ef9 in __glutProcessWindowWorkLists () at glut_event.c:1356
#6  0x00007ffff7682f6f in glutMainLoop () at glut_event.c:1377
#7  0x000000000042e7b1 in main ()
Unfortunately I don't know how to build the piglit tests with debugging 
symbols to investigate it further.

Regards,
Maciej

Re: [Mesa3d-dev] Piglit fbo tests

[Brian P. <br...@vm...>]

Maciej Cencora wrote:
> Dnia środa, 10 marca 2010 o 19:17:25 Maciej Cencora napisał(a):
>> Dnia środa, 10 marca 2010 o 16:36:01 Brian Paul napisał(a):
>>> Brian Paul wrote:
>>>> Maciej Cencora wrote:
>>>>> Hi,
>>>>>
>>>>> following 3 piglit tests are failing on r300 because they're trying to
>>>>> use GL_ARB_texture_non_power_of_two without checking if this extension
>>>>> is available:
>>>>>
>>>>> fbo-blit
>>>>> fbo-nodepth-test
>>>>> fbo-nostencil-test
>>>>>
>>>>> I'm not sure what solution is preferable, 1) change the teximage sizes
>>>>> to be POT, 2) require ARB_texture_npot.
>>>>> I've tried first solution for fbo-blit but it segfaults, trying to
>>>>> execute function at null address, so it would require some more
>>>>> investigation.
>>>> We should use POT texture sizes so that the test always does
>>>> _something_.
>>> I've fixed the fbo-blit test to use a POT texture.  Maybe you can fix
>>> the other tests similarly.
>>>
>>> BTW, I'm adding additional sub-tests to fbo-blit.c to investigate some
>>> other bugs I've recently found...
>>>
>>> -Brian
>> Sure, I'll look into it.
>>
>> Regards,
>> Maciej
>>
> 
> It looks like you've forgotten to remove  the ARB_npot check for fbo-blit. 

Fixed.


> After removing it the tests segfaults.
> #0  0x0000000000000000 in ?? ()
> #1  0x000000000042cfac in run_test ()
> #2  0x000000000042d1f3 in piglit_display ()
> #3  0x000000000042e639 in display ()
> #4  0x00007ffff7682ddf in processWindowWorkList (window=0x673a90) at 
> glut_event.c:1306
> #5  0x00007ffff7682ef9 in __glutProcessWindowWorkLists () at glut_event.c:1356
> #6  0x00007ffff7682f6f in glutMainLoop () at glut_event.c:1377
> #7  0x000000000042e7b1 in main ()
> Unfortunately I don't know how to build the piglit tests with debugging 
> symbols to investigate it further.

Run "ccmake ." and change CMAKE_BUILD_TYPE to "Debug".

-Brian

Re: [Mesa3d-dev] Piglit fbo tests

[Maciej C. <m.c...@gm...>]

Dnia środa, 10 marca 2010 o 19:35:48 Brian Paul napisał(a):
> Maciej Cencora wrote:
> > Dnia środa, 10 marca 2010 o 19:17:25 Maciej Cencora napisał(a):
> >> Dnia środa, 10 marca 2010 o 16:36:01 Brian Paul napisał(a):
> >>> Brian Paul wrote:
> >>>> Maciej Cencora wrote:
> >>>>> Hi,
> >>>>>
> >>>>> following 3 piglit tests are failing on r300 because they're trying
> >>>>> to use GL_ARB_texture_non_power_of_two without checking if this
> >>>>> extension is available:
> >>>>>
> >>>>> fbo-blit
> >>>>> fbo-nodepth-test
> >>>>> fbo-nostencil-test
> >>>>>
> >>>>> I'm not sure what solution is preferable, 1) change the teximage
> >>>>> sizes to be POT, 2) require ARB_texture_npot.
> >>>>> I've tried first solution for fbo-blit but it segfaults, trying to
> >>>>> execute function at null address, so it would require some more
> >>>>> investigation.
> >>>>
> >>>> We should use POT texture sizes so that the test always does
> >>>> _something_.
> >>>
> >>> I've fixed the fbo-blit test to use a POT texture.  Maybe you can fix
> >>> the other tests similarly.
> >>>
> >>> BTW, I'm adding additional sub-tests to fbo-blit.c to investigate some
> >>> other bugs I've recently found...
> >>>
> >>> -Brian
> >>
> >> Sure, I'll look into it.
> >>
> >> Regards,
> >> Maciej
> >
> > It looks like you've forgotten to remove  the ARB_npot check for
> > fbo-blit.
> 
> Fixed.
> 
> > After removing it the tests segfaults.
> > #0  0x0000000000000000 in ?? ()
> > #1  0x000000000042cfac in run_test ()
> > #2  0x000000000042d1f3 in piglit_display ()
> > #3  0x000000000042e639 in display ()
> > #4  0x00007ffff7682ddf in processWindowWorkList (window=0x673a90) at
> > glut_event.c:1306
> > #5  0x00007ffff7682ef9 in __glutProcessWindowWorkLists () at
> > glut_event.c:1356 #6  0x00007ffff7682f6f in glutMainLoop () at
> > glut_event.c:1377
> > #7  0x000000000042e7b1 in main ()
> > Unfortunately I don't know how to build the piglit tests with debugging
> > symbols to investigate it further.
> 
> Run "ccmake ." and change CMAKE_BUILD_TYPE to "Debug".
> 
> -Brian
> 

I'm sending fixes for fbo-blit and fbo-no-depth/stencil-test tests.

Regards,
Maciej

Re: [Mesa3d-dev] Piglit fbo tests

[Brian P. <br...@vm...>]

Maciej Cencora wrote:
> Dnia środa, 10 marca 2010 o 19:35:48 Brian Paul napisał(a):
>> Maciej Cencora wrote:
>>> Dnia środa, 10 marca 2010 o 19:17:25 Maciej Cencora napisał(a):
>>>> Dnia środa, 10 marca 2010 o 16:36:01 Brian Paul napisał(a):
>>>>> Brian Paul wrote:
>>>>>> Maciej Cencora wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> following 3 piglit tests are failing on r300 because they're trying
>>>>>>> to use GL_ARB_texture_non_power_of_two without checking if this
>>>>>>> extension is available:
>>>>>>>
>>>>>>> fbo-blit
>>>>>>> fbo-nodepth-test
>>>>>>> fbo-nostencil-test
>>>>>>>
>>>>>>> I'm not sure what solution is preferable, 1) change the teximage
>>>>>>> sizes to be POT, 2) require ARB_texture_npot.
>>>>>>> I've tried first solution for fbo-blit but it segfaults, trying to
>>>>>>> execute function at null address, so it would require some more
>>>>>>> investigation.
>>>>>> We should use POT texture sizes so that the test always does
>>>>>> _something_.
>>>>> I've fixed the fbo-blit test to use a POT texture.  Maybe you can fix
>>>>> the other tests similarly.
>>>>>
>>>>> BTW, I'm adding additional sub-tests to fbo-blit.c to investigate some
>>>>> other bugs I've recently found...
>>>>>
>>>>> -Brian
>>>> Sure, I'll look into it.
>>>>
>>>> Regards,
>>>> Maciej
>>> It looks like you've forgotten to remove  the ARB_npot check for
>>> fbo-blit.
>> Fixed.
>>
>>> After removing it the tests segfaults.
>>> #0  0x0000000000000000 in ?? ()
>>> #1  0x000000000042cfac in run_test ()
>>> #2  0x000000000042d1f3 in piglit_display ()
>>> #3  0x000000000042e639 in display ()
>>> #4  0x00007ffff7682ddf in processWindowWorkList (window=0x673a90) at
>>> glut_event.c:1306
>>> #5  0x00007ffff7682ef9 in __glutProcessWindowWorkLists () at
>>> glut_event.c:1356 #6  0x00007ffff7682f6f in glutMainLoop () at
>>> glut_event.c:1377
>>> #7  0x000000000042e7b1 in main ()
>>> Unfortunately I don't know how to build the piglit tests with debugging
>>> symbols to investigate it further.
>> Run "ccmake ." and change CMAKE_BUILD_TYPE to "Debug".
>>
>> -Brian
>>
> 
> I'm sending fixes for fbo-blit and fbo-no-depth/stencil-test tests.

Committed.  Thanks.

-Brian