From: <bug...@fr...> - 2009-06-30 20:32:28
|
http://bugs.freedesktop.org/show_bug.cgi?id=22561 Summary: Some GLX_SGIX_fbconfig functions improperly check direct extensions available when using indirect rendering Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: GLX AssignedTo: mes...@li... ReportedBy: jon...@dr... Created an attachment (id=27273) --> (http://bugs.freedesktop.org/attachment.cgi?id=27273) Patch which (incorrectly) removes the problematic calls to __glXExtensionBitIsEnabled() I'm using a Cygwin/X X server (which I'm writing some code for), which announces GLX version 1.2 and the GLX_SGIX_fbconfig extension Indirect rendering is forced for the client using LIBGL_ALWAYS_INDIRECT glxgears_fbconfig demo fails due to glXCreateContextWithConfigSGIX failing. The cause of this seems to be that the mesa implementation of glXGetFBConfigFromVisualSGIX() uses __glXExtensionBitIsEnabled() to check if the GLX_SGIX_fbconfig extension is available, but that function only checks if the extension is supported for direct rendering. Nothing else apart from these 3 functions from GLX_SGIX_fbconfig seems to use __glXExtensionBitIsEnabled, so I'm not sure exactly what the bug is here, or what the solution is. Attached is a patch which removes those checks, and allows glxgears_fbconfig to run successfully, but that's probably incorrect for the direct path. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@fr...> - 2009-07-03 10:54:30
|
http://bugs.freedesktop.org/show_bug.cgi?id=22561 Jon TURNEY <jon...@dr...> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27273|0 |1 is obsolete| | --- Comment #1 from Jon TURNEY <jon...@dr...> 2009-07-03 03:54:28 PST --- Created an attachment (id=27364) --> (http://bugs.freedesktop.org/attachment.cgi?id=27364) Patch to move initialization of ext_list_first_time out of DRI driver After a bit more staring at the code, the attached patch may be a more correct way to fix this: ext_list_first_time is only set in the DRI driver loader CreateScreen routine at the moment, so never gets set if DRI drivers are disabled by setting LIBGL_ALWAYS_INDIRECT. If ext_list_first_time isn't set, the screen's direct_support flags (which seems to be a bit misnamed as it actually reflects the extensions supported by the client/server combination when direct rendering isn't available) are never intialized, so when __glXExtensionBitIsEnabled() is used to check them, they are always false. So, this patch moves the initialization of ext_list_first_time out of the DRI driver loaders and up to where the screen config is allocated and initalized. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@fr...> - 2009-10-01 15:54:24
|
http://bugs.freedesktop.org/show_bug.cgi?id=22561 Jon TURNEY <jon...@dr...> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27364|0 |1 is obsolete| | --- Comment #2 from Jon TURNEY <jon...@dr...> 2009-10-01 06:26:12 PST --- Created an attachment (id=29975) --> (http://bugs.freedesktop.org/attachment.cgi?id=29975) Patch to move initialization of ext_list_first_time out of DRI driver Refreshed patch for git master -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@fr...> - 2009-10-01 15:54:25
|
http://bugs.freedesktop.org/show_bug.cgi?id=22561 Jon TURNEY <jon...@dr...> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some GLX_SGIX_fbconfig |psc->ext_list_first_time is |functions improperly check |not set correctly if |direct extensions available |LIBGL_ALWAYS_INDIRECT is |when using indirect |forced |rendering | --- Comment #3 from Jon TURNEY <jon...@dr...> 2009-10-01 06:28:22 PST --- Retitled the bug to reflect the more correct analysis of what's wrong in comment #1 -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@fr...> - 2010-03-05 19:31:41
|
http://bugs.freedesktop.org/show_bug.cgi?id=22561 Jon TURNEY <jon...@dr...> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29975|0 |1 is obsolete| | --- Comment #4 from Jon TURNEY <jon...@dr...> 2010-03-05 11:31:33 PST --- Created an attachment (id=33793) --> (http://bugs.freedesktop.org/attachment.cgi?id=33793) Patch to move initialization of ext_list_first_time to where it's storage is allocated Refreshed patch for git master -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@fr...> - 2010-03-05 21:59:54
|
http://bugs.freedesktop.org/show_bug.cgi?id=22561 Brian Paul <bri...@gm...> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Brian Paul <bri...@gm...> 2010-03-05 13:59:47 PST --- Committed. Thanks. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |