mesa3d-dev

[Mesa3d-dev] [Bug 26832] New: [bisected glx]: assert triggered by kwin, when glxCreateWindow is called with NULL attrib_list

[<bug...@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=26832

           Summary: [bisected glx]: assert triggered by kwin, when
                    glxCreateWindow is called with NULL attrib_list
           Product: Mesa
           Version: git
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: GLX
        AssignedTo: mes...@li...
        ReportedBy: Mag...@gm...


KDE's kwin calls glxCreateWindow with NULL as the attrib_list parameter when it
sets up OpenGL based compositing. Since Mesa commit
706fffbff59be0dc884e1938f1bdf731af1efa3e this triggers an assert in
CreateDrawable (glx_pbuffer.c:382), and the application crashes.

The man page for glxCreateWindow states explicitly that NULL is allowed to be
passed as a value to the attrib_list parameter
(http://www.opengl.org/sdk/docs/man/xhtml/glXCreateWindow.xml).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Mesa3d-dev] [Bug 26832] [bisected glx]: assert triggered by kwin, when glxCreateWindow is called with NULL attrib_list

[<bug...@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=26832





--- Comment #1 from Magnus Kessler <Mag...@gm...>  2010-03-01 22:50:14 PST ---
Created an attachment (id=33677)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=33677)
proposed fix

On closer inspection it appears that the variable "data" in glx_puffer.c
CreateDrawable is essentially unused. Removing this variable should fix the
issue of copying data from NULL, which commit
706fffbff59be0dc884e1938f1bdf731af1efa3e tried to guard against.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Mesa3d-dev] [Bug 26832] [bisected glx]: assert triggered by kwin, when glxCreateWindow is called with NULL attrib_list

[<bug...@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=26832


Brian Paul <bri...@gm...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Brian Paul <bri...@gm...>  2010-03-02 06:38:01 PST ---
The proposed fix is incorrect.  We need to append the attrib_list information
to the protocol request.  I'm replacing the assertion with a conditional.  See
commit 44f6bb1ddf2ffda93a8f1ecf3eca3f051939482b on master and
eede72b0f92ae49ed8c22f3210e615108a5e2b0a on the 7.7 branch.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.