mesa3d-dev

[Mesa3d-dev] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

[Peter C. <pc...@ca...>]

Fixes corruption with glBufferSubData on my machine,

Can someone review and push?

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)

[Mesa3d-dev] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

[Peter C. <pc...@ca...>]

Fixes corruption with glBufferSubData on my machine,

Can someone review and push?

(Resent with code comment fixed)

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)

Re: [Mesa3d-dev] [Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

[Chris W. <ch...@ch...>]

On Sat, 06 Nov 2010 10:04:31 +0000, Peter Clifton <pc...@ca...> wrote:
> Fixes corruption with glBufferSubData on my machine,
> 
> Can someone review and push?

Oddly, the pitch for BLT is in bytes and it should be sufficient to be a
multiple of element-size. Or two element-size depending on circumstances. 

Just to satisfy my curiosity, what happens with (1<<15 - 2)?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [Mesa3d-dev] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

[Eric A. <er...@an...>]

On Sat, 06 Nov 2010 09:23:06 +0000, Peter Clifton <pc...@ca...> wrote:
> Fixes corruption with glBufferSubData on my machine,
> 
> Can someone review and push?

Looks good.  Thanks!