[Merlinwork-developers] set_visible() and set_invisible()

[Valery S. <va...@bl...>]

Hello!
I've noticed inconvenience of using methods set_visible/set_invisible of
WIDGET object. Lets look at sample code that sets fields visibility based
on variable value:

if ($isVisible) {
  $this->mask->field1->set_visible();
  $this->mask->field2->set_visible();
  $this->mask->field3->set_visible();
} else {
  $this->mask->field1->set_invisible();
  $this->mask->field2->set_invisible();
  $this->mask->field3->set_invisible();
}

It will be better if this code will look like this:

$this->mask->field1->set_visible($isVisible);
$this->mask->field2->set_visible($isVisible);
$this->mask->field3->set_visible($isVisible);

I suggests to add one boolean parameter $visible to method WIDGET::set_visible
with default value of TRUE. This will let us use new better code ;-) while
conserve compatibility with old-style code.

Below is patched code (widget.php, lines 191-198):

  /**
   * Sets the widget visible or invisible.
   * @access public
   */
  function set_visible($visible = TRUE)
  {
   $this->visible = $visible;
  }

------------
Valery.