fix(station): corrected SDk to SDK

A powerful, open source messaging platform for modern devs

Brought to you by: yanivbh

#255 fix(station): corrected SDk to SDK

Status: closed

Owner: nobody

Labels: None

Updated: 2022-08-10

Created: 2022-08-08

Creator: Anonymous

Private: No

Originally created by: bsmirks

This is a fix for [#252] in which I found instances of the word SDk and replaced with SDK. Please let me know if anything was missed in the contribution workflow. Thanks!

Related

Discussion

Anonymous - 2022-08-09

Originally posted by: OrMemphis

Hey @bsmirks, all good with the contribution workflow!
I had a minor suggestion before merging, thanks a lot for your contribution.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2022-08-09

Originally posted by: bsmirks

Sounds good, I will play with implementing this and update the PR accordingly.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2022-08-09

Originally posted by: bsmirks

I've updated poison_messages.go before the first function is defined to contain a constant which stores the error message, then called it where needed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2022-08-10

Originally posted by: OrMemphis

@bsmirks thanks! :)

consider my suggestions;
if these messages are being used in parts, tell me and I'll approve and merge.
else, you can commit my suggestions and I'll approve.

btw you are more than welcome to our Discord server, I'm there if you have any question

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2022-08-10

Originally posted by: bsmirks

I have made a change to the name of the constant as suggested as I think that making the constant more descriptive is worthwhile in the long run for readability's sake.

However, I think that the bit about "Error while getting notified about..." should stay as is since it is being used in parts elsewhere like here which is where I got the convention for leaving it there and appending the constant afterwards. Let me know what you think!

Joined the Discord :)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2022-08-10

Ticket changed by: OrMemphis

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.