Menu

#873 MeGUI is not FIPS compliant and throws an unhandled exception

General
closed-fixed
nobody
None
5
2017-03-25
2017-02-06
Biolectron
No

Hi,

on FIPS-Enabled systems you get an exception (e.g. when choosing a video file for the avs input and clicking on "File Indexer"). The problem is, that MD5 is NOT a FIPS compliant hashing algorithm (because it's insecure).

You could use .NET's SHA512CryptoProvider instead:

in ChapterExtractor.ComputeMD5Sum(string path).

MD5CryptoServiceProvider().ComputeHash(...) => SHA512CryptoProvider().ComputeHash(...)

Do not use SHA1 please, as it will be retired soon and the FIPS compliance will be removed also.

Thanks!

1 Attachments

Discussion

  • Biolectron

    Biolectron - 2017-02-06

    It should be SHA512CryptoServiceProvider(), obviously! Sorry.

     
  • Zathor

    Zathor - 2017-02-10
    • status: open --> pending
     
  • Zathor

    Zathor - 2017-02-10

    Thanks for the report. To be honest I have no clue why the hash is calculated with MD5 at all as it is not used afterwards. I have removed it in 2704.

     
  • Zathor

    Zathor - 2017-03-25
    • status: pending --> closed-fixed
     

Log in to post a comment.