Building Hornet HNT-181 and -182 from XTRO Republic II
Compact heat sink type is displayed as '2 Compact Heat Sinkss' in unit display.
see attached screenshot.
What's going on here is that the heat sink type name is pulled from the MiscType entry for the particular heat sink. Basically, it searches through the 'mechs equipment list and and finds the first heat sink equipment, and uses that name.
The assumes that a 'mech can only have one type of heat sink, and so the first one it finds is the heatsink type for the whole unit.
Compact heat sinks are a little different because there are actually two MiscType entries, one for a single compact heat sink in one critical, and one for two. And these have different names too, "1 Compact Heat Sink" and "2 Compact Heat Sinks". So, in the Hornet, it finds the "2 Compact Heat Sinks" entry and uses that are the heat sink type name.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
From what I can see, the only real way to solve this is to have a special case for compact heat sinks and pull the name from somewhere else instead of the MiscType. I did this in Mech.getHeatSinkTypeName. Previously, all heat sinks flags were checked for and it just returned the Mounted.getName(). Now, compact heat sinks have their own check, and it just returns "Compact Heat Sink".
What's going on here is that the heat sink type name is pulled from the MiscType entry for the particular heat sink. Basically, it searches through the 'mechs equipment list and and finds the first heat sink equipment, and uses that name.
The assumes that a 'mech can only have one type of heat sink, and so the first one it finds is the heatsink type for the whole unit.
Compact heat sinks are a little different because there are actually two MiscType entries, one for a single compact heat sink in one critical, and one for two. And these have different names too, "1 Compact Heat Sink" and "2 Compact Heat Sinks". So, in the Hornet, it finds the "2 Compact Heat Sinks" entry and uses that are the heat sink type name.
Fixed in [r11970].
From what I can see, the only real way to solve this is to have a special case for compact heat sinks and pull the name from somewhere else instead of the MiscType. I did this in Mech.getHeatSinkTypeName. Previously, all heat sinks flags were checked for and it just returned the Mounted.getName(). Now, compact heat sinks have their own check, and it just returns "Compact Heat Sink".
Related
Commit: [r11970]