#4555 Aero - Losing altitude when striking/dive bombing

[Hammer]

Looks like we are doing the altitude change after the attack. Per this new errata the Altitude drop should be before the attack.

http://bg.battletech.com/forums/total-warfare/losing-altitude-when-strikingdive-bombing/msg1077020/#msg1077020

*New errata:

② Striking (p. 245)
First paragraph, third sentence

A strike attack reduces the attacker’s altitude by one.
Change to:
A strike attack reduces the attacker’s altitude by one, applied before any attacks are resolved that turn.

② Bombing (p. 245)
Under “Dive-Bombing”, first paragraph, in between the first and second sentences insert the following:

This altitude drop is applied before any attacks are resolved that turn.*

[Nicholas Walczak]

Fixed in [a386bf].

Previously, this was handled in Server.endCurrentPhase() for the firing phase. The first step was in Server.resolveOnlyWeaponAttacks(), where altitude loss for weapon attacks was tracked. Then, after Server.resolveOnlyWeaponAttacks() finishes, Server.resolveAeroAltitudeLoss() would be called, which would apply the altitude lose.

I removed the altitude loss tracking from resolveOnlyWeaponAttacks() and I removed Server.resolveAeroAltitudeLoss(). Instead, all of this logic was moved to Server.processAttack(), which is what is called when the client sends an attack packet to the server. Basically it goes through all the EntityActions and adds them to a collection to be processed later. Essentially at this point, a unit has committed ot its attacks and they cannot be undone, so the altitude loss is tallied and applied here.

The ultimate effect of this is that Aeros making strikes and dive bombs will be easier to hit for ground-to-air fire in the current firing phase.