#4208 Variants with quotes and mechset
The short overview is that special characters in Mech names (or at least quotation marks) do not work in the mechset files. To be precise, they're just ignored. For the details...
I noticed that there is art for the Hermes II HER-2M "Mercury" - however, it was using the default Hermes II art in MM. I figured this would be a simple fix, since the mechset simply hadn't been updated and still listed it as:
exact "Hermes II HER-2M" "mechs/HermesiiM.gif"
My first try to fix this, (though it was pretty obvious that this wouldn't work and it didn't):
exact "Hermes II HER-2M "Mercury"" "mechs/HermesiiM.gif"
But this didn't work either:
exact "Hermes II HER-2M "Mercury"" "mechs/HermesiiM.gif"
(While mentioning Hermes, the Hermes II HER-2K "Hermes III" also does not have working art for the same reason as the Hermes II M)
It appears that mechset.txt does not recognize special characters or at least not quotation marks.
Any double quotes in the unit name need escaped with a backslash:
\"Mercury\"
I've also been trying to avoid using Quotes. Even if it breaks the MUL rule.
Apparently the following works:
exact "Hermes II HER-2M \"Mercury\"" "mechs/HermesiiM.gif"
I've also noted the following other units with quotation marks need updated/added:
exact "Hermes II HER-4K \"Hermes III\"" "mechs/Hermesiii.gif"
exact "Catapult CPLT-C1 (Jenny) \"Butterbee\"" "mechs/CatapultC1.gif"
exact "Daishi (Dire Wolf) \"Prometheus\"" "mechs/direwolf_prometheus.gif"
exact "Daishi (Dire Wolf) \"Widowmaker\"" "mechs/direwolf_widowmaker.gif"
exact "Firestarter FS9-M \"Mirage\"" "mechs/FirestarterM.gif"
exact "Javelin JVN-10F \"Fire Javelin\"" "mechs/JavelinF.gif"
exact "Javelin JVN-11A \"Fire Javelin\"" "mechs/JavelinF.gif"
And not actually in quotes but still needs fixed, it did not have the parenthesis:
exact "Daishi (Dire Wolf) (Hohiro)" "mechs/direwolf_hohiro.gif"
Last edit: Alex 2014-07-23
This is good to know. I've always converted unit names with " " to ( ) in my personal copy of MM.
Whats the feeling here, should we change all the names back to match the MUL or leave what is changed. Given that I've done ALOT of name stuff I'm worried about breaking things, in particular MHQ campaigns.
Personally I think we should follow our established policy of "Match The MUL". If people can't be bothered to fix their campaigns, that's on them.
And at least the units with quotation marks I noted above are already matching the MUL in MM (unless you've changed them in the last 3-4 days) they just needed updates in mechset.txt to match their names.
One other issue this could affect is the inability to use " " in file names, which could affect fluff images, for those of us who use them.
Random example, you can't use a specific fluff picture for the unit Grasshopper GHR-7K "Gravedigger", since the filename Grasshopper GHR-7K "Gravedigger".gif is invalid..
That is a good point and one I hadn't thought of since I don't use fluff images. I suppose that is another tickmark in favor of replacing quotations with parentheses.
Actually that should have the same solution, so it is NOT a tick mark in favor of going with parens ;)
If it doesn't work, then it should be fixed in code so that it does work. For the simple reason of: If we have a policy, we should follow the policy.
Not really, you can't put \ in a file name either last I checked.
You don't put it in the filename. You put it in the mechset. Besides, there is nothing anywhere in our policies that says the image filenames have to follow the MUL. Just the unit names inside of MHQ. So the filename for the image could be Grasshopper GHR-7K - Gravedigger.gif just as easily. Which is a much better solution than breaking our own established policies.
The fluff images aren't in the mechset and are entirely file name driven last I checked.
Still something that can be fixed in code, either way. Unless someone is saying that it's because of Windoze not allowing double quotes in filenames. Cause Linux allows them just fine. :D
Yeah, well most of MM's users seem to use windows, so that's great but not helpful.
It was just being facetious :P
Seriously, that is something that if needed can be fixed in code to translate the " to ( and ) for fluff image checks... if Windoze really doesn't allow them.
I'm about to commit code for the issue raised by foji. Essentially it strips any double quotes from the Model for a unit so that the fluff filenames can be:
Grasshopper GHR-7K Gravedigger.gif
for the Grasshopper GHR-7K "Gravedigger" unit.
Double quote fluff filename stripping committed in [r11074]
Related
Commit: [r11074]
Yup, windows doesn't allow the following characters in file names
/ \ : * ? " < > |
Since I fixed the fluff issue as well, I've marked this as fixed.