#13 const char** conversion error at string_converter.cc: 135

0.10.0
closed-fixed
Jin
5
2007-12-21
2007-11-12
Anonymous
No

When building with FInk on Mac OSX Leopard, a compile error occurs in string_converter.cc on line 135.

The command to compile is:

g++ -DHAVE_CONFIG_H -I. -I. -I.. -I../tombupnp/upnp/inc -DXP_UNIX=1 -I/sw/include -I../src -I../tombupnp/ixml/inc -I../tombupnp/threadutil/inc -I../tombupnp/upnp/inc -I.. -I/sw/include/js -D_THREAD_SAFE -g -O2 -c -o libmediatomb_a-string_converter.o `test -f '../src/string_converter.cc' || echo './'`../src/string_converter.cc

If I modify the code and use the line without the type casting, then it compiles without error.

Discussion

  • Jin

    Jin - 2007-11-12

    Logged In: YES
    user_id=1205152
    Originator: NO

    Doh.. I think I changed that like 3 times back and forth and thought I had it... usually a standalone libiconv (that's what is used on OSX) needs the cast. So I guess they changed it on Leopard... probably time for a more sophisticated configure check.

    Unfortunately I can not test this since I have no OSX box around, I will add an extra check to configure this week and I would appreciate if you could do a quick test.

    Kind regards,
    Jin

     
  • terenius

    terenius - 2007-11-15

    Logged In: YES
    user_id=1938422
    Originator: NO

    Would be happy to.

     
  • Jin

    Jin - 2007-11-18

    Logged In: YES
    user_id=1205152
    Originator: NO

    Could you please try this package and see if it fixes it?
    http://www.deadlock.dhs.org/jin/iconv-test/mediatomb-0.11.0-pre.tar.gz

    Look for "checking if cast is needed for iconv... no" (or in your case "yes") message in configure, also autoconfig.h should have the ICONV_NEEDS_CAST define set as the result of the configure run.

    Thanks,
    Jin

     
  • terenius

    terenius - 2007-11-18

    Logged In: YES
    user_id=1938422
    Originator: NO

    Yes, it compile without errors now. The following lines are from configure:

    checking iconv.h usability... yes
    checking iconv.h presence... yes
    checking for iconv.h... yes
    checking for iconv... no
    checking for iconv in -liconv... yes
    checking if cast is needed for iconv... no

    Thanks!

     
  • Jin

    Jin - 2007-11-18

    Logged In: YES
    user_id=1205152
    Originator: NO

    crap, hehe, I forgot that the Leopard iconv behaviour does not need the cast, it's the same as on my Linux system; so on one side I am happy to hear that it works, but now I need a counter test on an older OSX version, to see if the check ever returns yes.

    do you happen to have access to an older box or do you know anyone who could test that?

    thanks!

     
  • Jin

    Jin - 2007-11-18

    Logged In: YES
    user_id=1205152
    Originator: NO

    Crap.. got this tested and it fails on the older OSX versions. So the check I did is no good... I need to find an older OSX box where I could test some things, once that is done I will come back and have to ask you for a retest on Leopard. Thanks!

     
  • Jin

    Jin - 2007-12-02

    Logged In: YES
    user_id=1205152
    Originator: NO

    Could you please test revision 1578 and tell me if it compiles now?

    I added a check that should hopefully cope with both situations correctly.

     
  • Jin

    Jin - 2007-12-21
    • assigned_to: nobody --> jin_eld
    • status: open --> closed-fixed
     
  • Jin

    Jin - 2007-12-21

    Logged In: YES
    user_id=1205152
    Originator: NO

    This got tested and should work now.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks