Re: [mdb-dev] More small fixes

[<br...@br...>]

On Mon, 8 Mar 2004 11:40:19 -0800 (PST), Jeff Smith wrote:

> 
> 1.) Way down in mdb_crack_row3, col_ptr is defined and initialized.
> This is C, so the definition really belongs with the other
definitions
> at the beginning of the function.  This was caught trying to compile
> on a machine with a slightly older version of GCC (2.95.3).
> 

Hmm...not my style, probably from a contributed patch.  Fixed in my
tree, will commit tonight with the others if I finish getting this
wood flooring put in (manual labor, ack!).

> 2.) In parser.y, I see one can compare constant with identifier,
> identifier with constant, and constant with constant.  Why would one
> compare constant with constant, and why can one not compare
identifier
> with identifier?  Also, comparing constant with constant does not
> free()
> up the parts of the expression, as the other comparisons do.

A common construct is "select * from table where 0=1"   The OpenOffice
odbc linkage does this for one, to get the list of column names.  It's
a quite portable and reliable way of doing it actually.

As far as identifier = identifier it's just not yet implemented.  It
needs some support in libmdb which isn't there...

> 3.) 'describe table' was giving me some strange values for size, and
I
> found the bug in src/sql/mdbsql.c, line 655.  The second arguement
> should be col_size, not tmpstr.

cut & paste error...my bad.