[mdb-dev] src/odbc/odbc.c

[Jeff S. <why...@ya...>]

Three things in src/odbc/odbc.c could use fixing.

1.) In SQLGetTypeInfo, there are two unusual definitions:

  unsigned char *row_buffer[MDB_PGSIZE]
  unsigned char *tmpstr[MDB_BIND_SIZE]

From the context, I highly doubt you meant to have these as arrays of
pointers.  These would make a lot more sense:   :-)

  unsigned char row_buffer[MDB_PGSIZE]
  unsigned char tmpstr[MDB_BIND_SIZE]

2.) There is a table near the beginning of src/odbc/odbc.c,
TypeInfo type_info[].  Several entries in the table contain NULL if four
fields that should contain 0.  Specifically unsigned_attribute,
sql_datetime_sub, num_prec_radix, and interval_precision.

3.) In SQLColAttributes, there is this line:
  *((char *)&rgbDesc[namelen])='\0';
It generates a warning on my compiler.  All you should need is:
  ((char *)rgbDesc)[namelen]='\0';

-- Jeff S


__________________________________
Do you Yahoo!?
Yahoo! Search - Find what you’re looking for faster
http://search.yahoo.com