Re: [mdb-dev] convert_to_ucs2

[<br...@br...>]

Yeah that was a quick fix when I noticed the results of the patch as
is.  I want to re-visit it today or tomorrow and move it down into
libmdb too.  The longer term solution is to use iconv for the
conversion, but I wanted to fix the bug quickly and then have some
time to think about fixing it right.  It will be more elegant in the
final version, I think I need to clean up some of the building of temp
table columns too....it's too verbose.  Should have it all done by
Monday.

Please check your patch against the tree, I used the row position
number from the tdef page to get the postion of the null bit instead
of a simple ordering of columns, and I consolidated the building of
the mask between pack_row[3|4] since it's identical.  So, please
verify that I didn't screw up the effects of your patch.

I'm having some problems running "list tables" in odbc which I need to
look at too.

Brian

On Fri, 5 Mar 2004 04:58:18 -0800 (PST), Jeff Smith wrote:

> 
> I would like to suggest a parameter change in convert_to_ucs2
> recently added to src/sql/mdbsql.c.  Add an additional
> parameter of int * into which the final size is stored.  That
> way, 1. you don't have to calculate it after you return, and
> 2. if logic for convert_to_ucs2 changes, you don't only have
> to update the logic for the string size in one place (high
> cohesion.
> 
>  -- Jeff S
> 
> __________________________________
> Do you Yahoo!?
> Yahoo! Search - Find what you�re looking for faster
> http://search.yahoo.com
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> mdbtools-dev mailing list
> mdb...@li...
> https://lists.sourceforge.net/lists/listinfo/mdbtools-dev