From: Jeff S. <why...@ya...> - 2004-03-05 13:13:00
|
I would like to suggest a parameter change in convert_to_ucs2 recently added to src/sql/mdbsql.c. Add an additional parameter of int * into which the final size is stored. That way, 1. you don't have to calculate it after you return, and 2. if logic for convert_to_ucs2 changes, you don't only have to update the logic for the string size in one place (high cohesion. -- Jeff S __________________________________ Do you Yahoo!? Yahoo! Search - Find what youre looking for faster http://search.yahoo.com |