Re: [mdb-dev] mdb-sql: Readline Completion Support

[Kyle R. B. <mo...@vo...>]

> Since I am basically just a lurker on this list, feel free to ignore
> these comments:
> 
> 1.)  It's generally easier to review patches if each patch does one
> thing.  i.e. you should keep your case insensitive SQL patch separate
> from your completion patch and attach both to your message if necessary.

That's good advice, thanks.  I had done several things in my local working 
copy of the software and didn't pay enough attention when I created the 
patch.  If the project wants the readline completion code, I can re-submit 
a patch based solely on that feature.

> 2.)  Gratuitous whitespace changes get in the way of what your patch is
> doing.  The reviewer has to waste time looking through the whitespace
> changes to see if you made any other changes in that section besides
> just the whitespace changes.

Another good point.  I had inadvertantly modified some lines while trying
to learn the code.  As you have pointed out, they shouldn't be included in
patches.  If either of these features are desired by the developers for
inclusion I can break them into their own patches.


Thank you for the advice.

Kyle R. Burton


-- 

------------------------------------------------------------------------------
Wisdom and Compassion are inseparable.
        -- Christmas Humphreys
mo...@vo...                            http://www.voicenet.com/~mortis
------------------------------------------------------------------------------