From: <kn...@gr...> - 2000-03-14 14:08:52
|
Date: Tue, 14 Mar 2000 08:27:41 -0500 (EST) From: Brian Bruns <ca...@um...> List-Id: MDB Tools development <mdbtools-dev.lists.sourceforge.net> Hi Karl, > On Mon, 13 Mar 2000 kn...@gr... wrote: > > > The calculation of number of fixed and variable columns doesn't work for > > some database material that I have. I have replaced a portion of > > data.c:mdb_read_row() with the following (perhaps non-optimal, but more > > accurate) algorithm. > > > > /* find out all the important stuff about the row */ > > > > num_cols = mdb->pg_buf [row_start]; > > var_cols = 0; > > fixed_cols = 0; > > for (j = 0; j < table->num_cols; j++) How about if we change this ^ to just num_cols, I think that'll take care of my concern...I'll put this in and look at the other stuff tonight (when I have a little more time, heading out the door now). I was toying with that. I didn't understand if there were the possibility that there were less than table->num_cols on a page. In that case, there might be an instance where the index (j, in this case) were not to start at 0 (e.g., one page has the first 4 columns, another page has the next 5, and a third page has the last 3; these would start 0, 4, 9, with corresponding changes in num_cols). That would complicate the algorithm somewhat. -- Karl -- |